From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55916 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PPjVo-0008Qm-UF
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 17:26:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agl@us.ibm.com>) id 1PPjVn-0000R2-LM
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 17:26:24 -0500
Received: from e37.co.us.ibm.com ([32.97.110.158]:45275)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agl@us.ibm.com>) id 1PPjVn-0000Qt-F3
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 17:26:23 -0500
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com
	[9.17.195.227])
	by e37.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id oB6MNv6n030102
	for <qemu-devel@nongnu.org>; Mon, 6 Dec 2010 15:23:57 -0700
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	oB6MQG8K215140
	for <qemu-devel@nongnu.org>; Mon, 6 Dec 2010 15:26:16 -0700
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id oB6MQFCM017800
	for <qemu-devel@nongnu.org>; Mon, 6 Dec 2010 15:26:15 -0700
From: Adam Litke <agl@us.ibm.com>
In-Reply-To: <1291399402-20366-20-git-send-email-mdroth@linux.vnet.ibm.com>
References: <1291399402-20366-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1291399402-20366-20-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 06 Dec 2010 16:26:14 -0600
Message-ID: <1291674374.2213.10.camel@aglitke>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC][PATCH v5 19/21] virtagent: add virtagent
	guest daemon
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, abeekhof@redhat.com

On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote:
> +static void usage(const char *cmd)
> +{
> +    printf(
> +"Usage: %s -c <channel_opts>\n"
> +"QEMU virtagent guest agent\n"
> +"\n"
> +"  -c, --channel     channel options of the form:\n"
> +"                    <method>:<addr>:<port>[:channel_id]\n"
> +"  -v, --verbose     display extra debugging information\n"
> +"  -h, --help        display this help and exit\n"
> +"\n"
> +"  channels are used to establish a data connection between 2 end-points in\n"
> +"  the host or the guest (connection method specified by <method>).\n"
> +"  The positional parameters for channels are:\n"
> +"\n"
> +"  <method>:     one of unix-connect, unix-listen, tcp-connect, tcp-listen,\n"
> +"                virtserial-open\n"

The usage information doesn't agree with the parameters the program
accepts (virtserial-open -> virtio-serial)

> +"  <addr>:       path of unix socket or virtserial port, or IP of host, to\n"
> +"                connect/bind to\n"
> +"  <port>:       port to bind/connect to, or '-' if addr is a path\n"
> +"\n"
> +"Report bugs to <mdroth@linux.vnet.ibm.com>\n"
> +    , cmd);
> +}

-- 
Thanks,
Adam