From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51195 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPtxq-0006B1-SR for qemu-devel@nongnu.org; Tue, 07 Dec 2010 04:36:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPtxp-0001QL-Oo for qemu-devel@nongnu.org; Tue, 07 Dec 2010 04:36:02 -0500 Received: from mtagate3.uk.ibm.com ([194.196.100.163]:40932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPtxp-0001Pm-Dd for qemu-devel@nongnu.org; Tue, 07 Dec 2010 04:36:01 -0500 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate3.uk.ibm.com (8.13.1/8.13.1) with ESMTP id oB79Zxf6005208 for ; Tue, 7 Dec 2010 09:35:59 GMT Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oB79a0eV3280928 for ; Tue, 7 Dec 2010 09:36:00 GMT Received: from d06av05.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oB79Zw5i013004 for ; Tue, 7 Dec 2010 02:35:59 -0700 From: Stefan Hajnoczi Date: Tue, 7 Dec 2010 09:35:55 +0000 Message-Id: <1291714556-22961-4-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1291714556-22961-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1291714556-22961-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 3/4] qemu-img: Free option parameter lists in img_create() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi Free option parameter lists in the img_create() error return path. Signed-off-by: Stefan Hajnoczi --- qemu-img.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 5b6e648..23bb7dc 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -439,8 +439,6 @@ static int img_create(int argc, char **argv) puts(""); ret = bdrv_create(drv, filename, param); - free_option_parameters(create_options); - free_option_parameters(param); if (ret < 0) { if (ret == -ENOTSUP) { @@ -452,6 +450,8 @@ static int img_create(int argc, char **argv) } } out: + free_option_parameters(create_options); + free_option_parameters(param); if (ret) { return 1; } -- 1.7.2.3