From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33586 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQ1W3-0008AS-OG for qemu-devel@nongnu.org; Tue, 07 Dec 2010 12:39:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQ1W2-0000n9-KU for qemu-devel@nongnu.org; Tue, 07 Dec 2010 12:39:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQ1W2-0000mz-CB for qemu-devel@nongnu.org; Tue, 07 Dec 2010 12:39:50 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB7HdmU7012593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 7 Dec 2010 12:39:49 -0500 From: Jes.Sorensen@redhat.com Date: Tue, 7 Dec 2010 18:39:46 +0100 Message-Id: <1291743586-3518-1-git-send-email-Jes.Sorensen@redhat.com> Subject: [Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kwolf@redhat.com Cc: qemu-devel@nongnu.org From: Jes Sorensen This cleans up the handling of image size in img_create() by parsing the value early, and then only setting it once if a value has been added as the last argument to the command line. Signed-off-by: Jes Sorensen --- qemu-img.c | 19 +++++++++++-------- 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index d146d8c..eaec725 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -282,6 +282,7 @@ static int add_old_style_options(const char *fmt, QEMUOptionParameter *list, static int img_create(int argc, char **argv) { int c, ret = 0; + uint64_t img_size = 0; const char *fmt = "raw"; const char *base_fmt = NULL; const char *filename; @@ -329,6 +330,11 @@ static int img_create(int argc, char **argv) } filename = argv[optind++]; + /* Get image size, if specified */ + if (optind < argc) { + img_size = strtosz(argv[optind++], NULL); + } + if (options && !strcmp(options, "?")) { ret = print_block_option_help(filename, fmt); goto out; @@ -356,7 +362,6 @@ static int img_create(int argc, char **argv) /* Create parameter list with default values */ param = parse_option_parameters("", create_options, param); - set_option_parameter_int(param, BLOCK_OPT_SIZE, -1); /* Parse -o options */ if (options) { @@ -368,21 +373,19 @@ static int img_create(int argc, char **argv) } } - /* Add size to parameters */ - if (optind < argc) { - set_option_parameter(param, BLOCK_OPT_SIZE, argv[optind++]); - } - /* Add old-style options to parameters */ ret = add_old_style_options(fmt, param, base_filename, base_fmt); if (ret < 0) { goto out; } + if (img_size) { + set_option_parameter_int(param, BLOCK_OPT_SIZE, img_size); + } + // The size for the image must always be specified, with one exception: // If we are using a backing file, we can obtain the size from there - if (get_option_parameter(param, BLOCK_OPT_SIZE)->value.n == -1) { - + if (get_option_parameter(param, BLOCK_OPT_SIZE)->value.n == 0) { QEMUOptionParameter *backing_file = get_option_parameter(param, BLOCK_OPT_BACKING_FILE); QEMUOptionParameter *backing_fmt = -- 1.7.3.2