From: Alexander Graf <agraf@suse.de>
To: QEMU-devel Developers <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH 13/15] heathrow_pic: Declare as little endian
Date: Wed, 8 Dec 2010 12:05:48 +0100 [thread overview]
Message-ID: <1291806350-9646-14-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1291806350-9646-1-git-send-email-agraf@suse.de>
This patch replaces explicit bswaps with endianness hints to the
mmio layer.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
hw/heathrow_pic.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/hw/heathrow_pic.c b/hw/heathrow_pic.c
index 390b63c..b19b754 100644
--- a/hw/heathrow_pic.c
+++ b/hw/heathrow_pic.c
@@ -68,7 +68,6 @@ static void pic_writel (void *opaque, target_phys_addr_t addr, uint32_t value)
HeathrowPIC *pic;
unsigned int n;
- value = bswap32(value);
n = ((addr & 0xfff) - 0x10) >> 4;
PIC_DPRINTF("writel: " TARGET_FMT_plx " %u: %08x\n", addr, n, value);
if (n >= 2)
@@ -118,7 +117,6 @@ static uint32_t pic_readl (void *opaque, target_phys_addr_t addr)
}
}
PIC_DPRINTF("readl: " TARGET_FMT_plx " %u: %08x\n", addr, n, value);
- value = bswap32(value);
return value;
}
@@ -223,7 +221,7 @@ qemu_irq *heathrow_pic_init(int *pmem_index,
/* only 1 CPU */
s->irqs = irqs[0];
*pmem_index = cpu_register_io_memory(pic_read, pic_write, s,
- DEVICE_NATIVE_ENDIAN);
+ DEVICE_LITTLE_ENDIAN);
register_savevm(NULL, "heathrow_pic", -1, 1, heathrow_pic_save,
heathrow_pic_load, s);
--
1.6.0.2
next prev parent reply other threads:[~2010-12-08 11:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 11:05 [Qemu-devel] [PATCH 00/15] MMIO endianness cleanup v2 Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 01/15] exec: introduce endianness swapped mmio Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 02/15] Add endianness as io mem parameter Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 03/15] Make simple io mem handler endian aware Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 04/15] dbdma: Make little endian Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 05/15] pci-host: Delegate bswap to mmio layer Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 06/15] uninorth: Get rid of bswap Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 07/15] e1000: Make little endian Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 08/15] prep: Declare as " Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 09/15] versatile_pci: " Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 10/15] ppc4xx_pci: " Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 11/15] openpic: Replace explicit byte swap with endian hints Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 12/15] rtl8139: Declare as little endian Alexander Graf
2010-12-08 11:05 ` Alexander Graf [this message]
2010-12-08 11:05 ` [Qemu-devel] [PATCH 14/15] isa_mmio: Always use " Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 15/15] usb_ohci: " Alexander Graf
2010-12-11 18:02 ` [Qemu-devel] Re: [PATCH 00/15] MMIO endianness cleanup v2 Blue Swirl
-- strict thread matches above, loose matches on Subject: below --
2010-11-30 14:35 [Qemu-devel] [PATCH 00/15] [PATCH] MMIO endianness cleanup v1 Alexander Graf
2010-11-30 14:35 ` [Qemu-devel] [PATCH 13/15] heathrow_pic: Declare as little endian Alexander Graf
2010-11-25 7:35 [Qemu-devel] [PATCH 00/15] [RFC] MMIO endianness cleanup Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 13/15] heathrow_pic: Declare as little endian Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291806350-9646-14-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).