From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35488 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTBdX-0006J3-D4 for qemu-devel@nongnu.org; Thu, 16 Dec 2010 06:04:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTBdW-0007zZ-5X for qemu-devel@nongnu.org; Thu, 16 Dec 2010 06:04:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTBdV-0007zR-Uo for qemu-devel@nongnu.org; Thu, 16 Dec 2010 06:04:38 -0500 From: Jes.Sorensen@redhat.com Date: Thu, 16 Dec 2010 12:04:14 +0100 Message-Id: <1292497454-32573-4-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1292497454-32573-1-git-send-email-Jes.Sorensen@redhat.com> References: <1292497454-32573-1-git-send-email-Jes.Sorensen@redhat.com> Subject: [Qemu-devel] [PATCH 3/3] Prevent creating an image with the same filename as backing file List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kwolf@redhat.com Cc: qemu-devel@nongnu.org, armbru@redhat.com, stefanha@linux.vnet.ibm.com From: Jes Sorensen Signed-off-by: Jes Sorensen --- block.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 765f9f3..027dc6a 100644 --- a/block.c +++ b/block.c @@ -2769,6 +2769,13 @@ int bdrv_img_create(const char *filename, const char *fmt, BlockDriver *drv, *proto_drv; int ret = 0; + if (!strcmp(filename, base_filename)) { + error_report("Error: Trying to create a snapshot with the same " + "filename as the backing file"); + ret = -1; + goto out; + } + /* Find driver and parse its options */ drv = bdrv_find_format(fmt); if (!drv) { -- 1.7.3.3