From: Jes.Sorensen@redhat.com
To: kwolf@redhat.com
Cc: qemu-devel@nongnu.org, armbru@redhat.com, stefanha@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v3 0/4] Re-factor img_create() and add live snapshots
Date: Thu, 16 Dec 2010 13:52:14 +0100 [thread overview]
Message-ID: <1292503938-10167-1-git-send-email-Jes.Sorensen@redhat.com> (raw)
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Hi,
This set of patches re-factors img_create() and moves the core part of
it into block.c so it can be accessed from qemu as well as
qemu-img. The second patch adds basic live snapshots support to the
code, however only snapshots to external QCOW2 images is supported for
now. QED support should be trivial once the QED patches go into
upstream.
The last patch fixes a small gotcha which is present in the old code
as well. Try to catch cases where a user tries to create an image with
itself as the backing file. QEMU does 'interesting' things when you do
this.....
Many thanks to Kevin for his help with block layer internals!
New in v2:
- Fix error return value in monitor command
- Clarify help message for command
- Fix patch conflict against block tree. It's all Stefan's fault :)
f8feb11f4d76f390dddc5cc5345abf99f7659a78
New in v3:
- Address issues pointed out by Stefan and Kevin
- Additional patch to return proper -errno error values on error in
bdrv_img_create() as suggested by Kevin.
Jes Sorensen (4):
qemu-img.c: Re-factor img_create()
Introduce do_snapshot_blkdev() and monitor command to handle it.
Prevent creating an image with the same filename as backing file
bdrv_img_create() use proper errno return values
block.c | 145 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
block.h | 4 ++
blockdev.c | 62 +++++++++++++++++++++++
blockdev.h | 1 +
hmp-commands.hx | 19 +++++++
qemu-img.c | 108 +----------------------------------------
6 files changed, 233 insertions(+), 106 deletions(-)
--
1.7.3.3
next reply other threads:[~2010-12-16 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 12:52 Jes.Sorensen [this message]
2010-12-16 12:52 ` [Qemu-devel] [PATCH 1/4] qemu-img.c: Re-factor img_create() Jes.Sorensen
2010-12-16 12:52 ` [Qemu-devel] [PATCH 2/4] Introduce do_snapshot_blkdev() and monitor command to handle it Jes.Sorensen
2010-12-16 12:52 ` [Qemu-devel] [PATCH 3/4] Prevent creating an image with the same filename as backing file Jes.Sorensen
2010-12-16 12:52 ` [Qemu-devel] [PATCH 4/4] bdrv_img_create() use proper errno return values Jes.Sorensen
2010-12-16 14:21 ` [Qemu-devel] Re: [PATCH v3 0/4] Re-factor img_create() and add live snapshots Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292503938-10167-1-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).