From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57614 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PUnUO-0005L2-Ax
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:41:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1PUnQy-0000xu-Te
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:38:21 -0500
Received: from mailout-de.gmx.net ([213.165.64.23]:46835 helo=mail.gmx.net)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1PUnQy-0000xa-IA
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:38:20 -0500
Date: Mon, 20 Dec 2010 22:36:41 +0100
Message-Id: <1292881001$3121@local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
From: Sebastian Herbszt <herbszt@gmx.de>
Subject: [Qemu-devel] [PATCH] rtl8139: use pci_config_set_revision()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Sebastian Herbszt <herbszt@gmx.de>

Use pci_config_set_revision().

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>

diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index a8aed89..6407ce0 100644
--- a/hw/rtl8139.c
+++ b/hw/rtl8139.c
@@ -3346,7 +3346,7 @@ static int pci_rtl8139_init(PCIDevice *dev)
     pci_conf = s->dev.config;
     pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_REALTEK);
     pci_config_set_device_id(pci_conf, PCI_DEVICE_ID_REALTEK_8139);
-    pci_conf[PCI_REVISION_ID] = RTL8139_PCI_REVID; /* >=0x20 is for 8139C+ */
+    pci_config_set_revision(pci_conf, RTL8139_PCI_REVID); /* >=0x20 is for 8139C+ */
     pci_config_set_class(pci_conf, PCI_CLASS_NETWORK_ETHERNET);
     pci_conf[PCI_INTERRUPT_PIN] = 1;    /* interrupt pin 0 */
     /* TODO: start of capability list, but no capability