From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwsIn-00038Y-Jr for qemu-devel@nongnu.org; Thu, 02 Aug 2012 06:06:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwsIf-0000VA-MW for qemu-devel@nongnu.org; Thu, 02 Aug 2012 06:06:45 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:51368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwsIf-0000V1-Ew for qemu-devel@nongnu.org; Thu, 02 Aug 2012 06:06:37 -0400 Date: Thu, 2 Aug 2012 06:06:36 -0400 (EDT) From: Miroslav Rezanina Message-ID: <1293024006.7532127.1343901996210.JavaMail.root@redhat.com> In-Reply-To: <5019037A.8040601@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org ----- Original Message ----- > From: "Paolo Bonzini" > To: "Miroslav Rezanina" > Cc: qemu-devel@nongnu.org > Sent: Wednesday, August 1, 2012 12:22:50 PM > Subject: Re: [PATCH][RFC] Add compare subcommand for qemu-img > > > + goto out; > > + } > > + } > > + over_num += nb_sectors; > > + qemu_progress_print(((float) nb_sectors / > > progress_base)*100, 100); > > qemu_progress_print(nb_sectors, over_sectors); > > > Paolo > This won't work. qemu_progress_print takes either (current_progress,0) or (progress_delta,progress_part) where all values are in percents - values in range (0,100). If we pass (nb_sectors,over_sectors) we get 100% thanks to the formula: nb_sectors / 100 * over_sectors Mirek