From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v3 04/15] fix sparse support (?)
Date: Thu, 23 Dec 2010 11:43:51 +0100 [thread overview]
Message-ID: <1293101042-13121-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1293101042-13121-1-git-send-email-pbonzini@redhat.com>
I didn't test with sparse, but the old code using += before a variable
was set was wrong. Sparse support should probably be ripped out or
redone, but this at least keeps some sanity.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 5237b6e..d9277fe 100755
--- a/configure
+++ b/configure
@@ -2737,17 +2737,17 @@ echo "INSTALL_PROG=$install -m0755 -p" >> $config_host_mak
echo "CC=$cc" >> $config_host_mak
echo "CC_I386=$cc_i386" >> $config_host_mak
echo "HOST_CC=$host_cc" >> $config_host_mak
-if test "$sparse" = "yes" ; then
- echo "CC := REAL_CC=\"\$(CC)\" cgcc" >> $config_host_mak
- echo "HOST_CC := REAL_CC=\"\$(HOST_CC)\" cgcc" >> $config_host_mak
- echo "QEMU_CFLAGS += -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-non-pointer-null" >> $config_host_mak
-fi
echo "AR=$ar" >> $config_host_mak
echo "OBJCOPY=$objcopy" >> $config_host_mak
echo "LD=$ld" >> $config_host_mak
echo "WINDRES=$windres" >> $config_host_mak
echo "CFLAGS=$CFLAGS" >> $config_host_mak
echo "QEMU_CFLAGS=$QEMU_CFLAGS" >> $config_host_mak
+if test "$sparse" = "yes" ; then
+ echo "CC := REAL_CC=\"\$(CC)\" cgcc" >> $config_host_mak
+ echo "HOST_CC := REAL_CC=\"\$(HOST_CC)\" cgcc" >> $config_host_mak
+ echo "QEMU_CFLAGS += -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-non-pointer-null" >> $config_host_mak
+fi
echo "HELPER_CFLAGS=$helper_cflags" >> $config_host_mak
echo "LDFLAGS=$LDFLAGS" >> $config_host_mak
echo "ARLIBS_BEGIN=$arlibs_begin" >> $config_host_mak
--
1.7.3.2
next prev parent reply other threads:[~2010-12-23 10:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 10:43 [Qemu-devel] [PATCH v3 00/15] preparation for autoconfy configure script Paolo Bonzini
2010-12-23 10:43 ` [Qemu-devel] [PATCH v3 01/15] default compilation tools to environment variables Paolo Bonzini
2010-12-23 10:43 ` [Qemu-devel] [PATCH v3 02/15] default make and install " Paolo Bonzini
2010-12-23 10:43 ` [Qemu-devel] [PATCH v3 03/15] move feature variables to the top Paolo Bonzini
2010-12-23 10:43 ` Paolo Bonzini [this message]
2010-12-23 10:43 ` [Qemu-devel] [PATCH v3 05/15] test cc with the complete set of chosen flags Paolo Bonzini
2010-12-23 10:43 ` [Qemu-devel] [PATCH v3 06/15] do not pass bogus $(SRC_PATH) include paths to cc during configure Paolo Bonzini
2010-12-23 10:43 ` [Qemu-devel] [PATCH v3 07/15] provide portable HOST_LONG_BITS test Paolo Bonzini
2010-12-23 10:43 ` [Qemu-devel] [PATCH v3 08/15] fix spelling of $pkg_config, move default together with other cross tools Paolo Bonzini
2010-12-23 10:43 ` [Qemu-devel] [PATCH v3 09/15] do not default to non-prefixed pkg-config when cross compiling Paolo Bonzini
2010-12-23 10:43 ` [Qemu-devel] [PATCH v3 10/15] reorganize sdl-config tests Paolo Bonzini
2010-12-23 10:43 ` [Qemu-devel] [PATCH v3 11/15] move "ln -sf" emulation to a function Paolo Bonzini
2010-12-23 10:43 ` [Qemu-devel] [PATCH v3 12/15] remove source_path_used Paolo Bonzini
2010-12-23 10:44 ` [Qemu-devel] [PATCH v3 13/15] move --srcdir detection earlier Paolo Bonzini
2010-12-23 10:44 ` [Qemu-devel] [PATCH v3 14/15] remove HOST_CC mention from roms/{sea, vga}bios/config.mak Paolo Bonzini
2010-12-23 10:44 ` [Qemu-devel] [PATCH v3 15/15] make trace options use autoconfy names Paolo Bonzini
2011-01-14 9:58 ` [Qemu-devel] Re: [PATCH v3 00/15] preparation for autoconfy configure script Paolo Bonzini
2011-01-14 17:57 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293101042-13121-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).