qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 8/8] fix QemuOpts leak
Date: Thu, 23 Dec 2010 13:42:54 +0100	[thread overview]
Message-ID: <1293108174-24895-9-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1293108174-24895-1-git-send-email-pbonzini@redhat.com>

Now that no backend's open function saves the passed QemuOpts, fix a leak
in the qemu_chr_open backwards-compatible parser.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 qemu-char.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/qemu-char.c b/qemu-char.c
index 7b61a62..b99b77b 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2555,6 +2555,7 @@ CharDriverState *qemu_chr_open(const char *label, const char *filename, void (*i
     if (chr && qemu_opt_get_bool(opts, "mux", 0)) {
         monitor_init(chr, MONITOR_USE_READLINE);
     }
+    qemu_opts_del(opts);
     return chr;
 }
 
-- 
1.7.3.2

  parent reply	other threads:[~2010-12-23 12:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-23 12:42 [Qemu-devel] [PATCH 0/8] make -qmp stdio usable Paolo Bonzini
2010-12-23 12:42 ` [Qemu-devel] [PATCH 1/8] remove broken code for tty Paolo Bonzini
2010-12-23 12:42 ` [Qemu-devel] [PATCH 2/8] add qemu_chr_set_echo Paolo Bonzini
2010-12-23 12:42 ` [Qemu-devel] [PATCH 3/8] move atexit(term_exit) and O_NONBLOCK to qemu_chr_open_stdio Paolo Bonzini
2010-12-23 12:42 ` [Qemu-devel] [PATCH 4/8] add set_echo implementation for qemu_chr_stdio Paolo Bonzini
2010-12-23 12:42 ` [Qemu-devel] [PATCH 5/8] create TextConsole together with the CharDeviceState Paolo Bonzini
2010-12-23 12:42 ` [Qemu-devel] [PATCH 6/8] add set_echo implementation for text consoles Paolo Bonzini
2010-12-23 12:42 ` [Qemu-devel] [PATCH 7/8] remove text_console_opts Paolo Bonzini
2010-12-23 12:42 ` Paolo Bonzini [this message]
2011-01-14  9:56 ` [Qemu-devel] Re: [PATCH 0/8] make -qmp stdio usable Paolo Bonzini
2011-01-28 12:59 ` [Qemu-devel] " Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1293108174-24895-9-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).