From: Pierre Riteau <Pierre.Riteau@irisa.fr>
To: qemu-devel@nongnu.org
Cc: Pierre Riteau <Pierre.Riteau@irisa.fr>
Subject: [Qemu-devel] [PATCH] Avoid divide by zero when there is no block device to migrate
Date: Sat, 25 Dec 2010 21:52:10 +0100 [thread overview]
Message-ID: <1293310330-12067-1-git-send-email-Pierre.Riteau@irisa.fr> (raw)
When block migration is requested and no read-write block device is
present, a divide by zero exception is triggered because
total_sector_sum equals zero.
Signed-off-by: Pierre Riteau <Pierre.Riteau@irisa.fr>
---
block-migration.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/block-migration.c b/block-migration.c
index 1475325..d62d63e 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -350,7 +350,11 @@ static int blk_mig_save_bulked_block(Monitor *mon, QEMUFile *f)
}
}
- progress = completed_sector_sum * 100 / block_mig_state.total_sector_sum;
+ if (block_mig_state.total_sector_sum != 0) {
+ progress = completed_sector_sum * 100 / block_mig_state.total_sector_sum;
+ } else {
+ progress = 100;
+ }
if (progress != block_mig_state.prev_progress) {
block_mig_state.prev_progress = progress;
qemu_put_be64(f, (progress << BDRV_SECTOR_BITS)
--
1.7.3.4
next reply other threads:[~2010-12-25 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-25 20:52 Pierre Riteau [this message]
2011-01-09 19:37 ` [Qemu-devel] Re: [PATCH] Avoid divide by zero when there is no block device to migrate Pierre Riteau
2011-01-11 11:54 ` [Qemu-devel] " Kevin Wolf
2011-01-12 11:01 ` Pierre Riteau
2011-01-12 11:40 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293310330-12067-1-git-send-email-Pierre.Riteau@irisa.fr \
--to=pierre.riteau@irisa.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).