From: "Andreas Färber" <andreas.faerber@web.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <andreas.faerber@web.de>
Subject: [Qemu-devel] [PATCH] ioport: Improve error output
Date: Mon, 27 Dec 2010 01:00:56 +0100 [thread overview]
Message-ID: <1293408056-45428-1-git-send-email-andreas.faerber@web.de> (raw)
When failing due to conflicting I/O port registrations,
include the offending I/O port address in the message.
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
---
ioport.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ioport.c b/ioport.c
index aa4188a..349915f 100644
--- a/ioport.c
+++ b/ioport.c
@@ -149,7 +149,7 @@ int register_ioport_read(pio_addr_t start, int length, int size,
for(i = start; i < start + length; i += size) {
ioport_read_table[bsize][i] = func;
if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
- hw_error("register_ioport_read: invalid opaque");
+ hw_error("register_ioport_read: invalid opaque for 0x%x", i);
ioport_opaque[i] = opaque;
}
return 0;
@@ -168,7 +168,7 @@ int register_ioport_write(pio_addr_t start, int length, int size,
for(i = start; i < start + length; i += size) {
ioport_write_table[bsize][i] = func;
if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
- hw_error("register_ioport_write: invalid opaque");
+ hw_error("register_ioport_write: invalid opaque for 0x%x", i);
ioport_opaque[i] = opaque;
}
return 0;
--
1.7.3.4
next reply other threads:[~2010-12-27 0:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 0:00 Andreas Färber [this message]
2011-01-20 11:48 ` [Qemu-devel] [PATCH] ioport: Improve error output Aurelien Jarno
2011-03-06 14:48 ` [Qemu-devel] [PATCH v2] " Andreas Färber
2011-03-06 20:02 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293408056-45428-1-git-send-email-andreas.faerber@web.de \
--to=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).