* [Qemu-devel] [PATCH] ioport: Improve error output
@ 2010-12-27 0:00 Andreas Färber
2011-01-20 11:48 ` Aurelien Jarno
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2010-12-27 0:00 UTC (permalink / raw)
To: qemu-devel; +Cc: Andreas Färber
When failing due to conflicting I/O port registrations,
include the offending I/O port address in the message.
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
---
ioport.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ioport.c b/ioport.c
index aa4188a..349915f 100644
--- a/ioport.c
+++ b/ioport.c
@@ -149,7 +149,7 @@ int register_ioport_read(pio_addr_t start, int length, int size,
for(i = start; i < start + length; i += size) {
ioport_read_table[bsize][i] = func;
if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
- hw_error("register_ioport_read: invalid opaque");
+ hw_error("register_ioport_read: invalid opaque for 0x%x", i);
ioport_opaque[i] = opaque;
}
return 0;
@@ -168,7 +168,7 @@ int register_ioport_write(pio_addr_t start, int length, int size,
for(i = start; i < start + length; i += size) {
ioport_write_table[bsize][i] = func;
if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
- hw_error("register_ioport_write: invalid opaque");
+ hw_error("register_ioport_write: invalid opaque for 0x%x", i);
ioport_opaque[i] = opaque;
}
return 0;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] ioport: Improve error output
2010-12-27 0:00 [Qemu-devel] [PATCH] ioport: Improve error output Andreas Färber
@ 2011-01-20 11:48 ` Aurelien Jarno
2011-03-06 14:48 ` [Qemu-devel] [PATCH v2] " Andreas Färber
0 siblings, 1 reply; 4+ messages in thread
From: Aurelien Jarno @ 2011-01-20 11:48 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-devel
On Mon, Dec 27, 2010 at 01:00:56AM +0100, Andreas Färber wrote:
> When failing due to conflicting I/O port registrations,
> include the offending I/O port address in the message.
>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> ---
> ioport.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ioport.c b/ioport.c
> index aa4188a..349915f 100644
> --- a/ioport.c
> +++ b/ioport.c
> @@ -149,7 +149,7 @@ int register_ioport_read(pio_addr_t start, int length, int size,
> for(i = start; i < start + length; i += size) {
> ioport_read_table[bsize][i] = func;
> if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
> - hw_error("register_ioport_read: invalid opaque");
> + hw_error("register_ioport_read: invalid opaque for 0x%x", i);
> ioport_opaque[i] = opaque;
> }
> return 0;
> @@ -168,7 +168,7 @@ int register_ioport_write(pio_addr_t start, int length, int size,
> for(i = start; i < start + length; i += size) {
> ioport_write_table[bsize][i] = func;
> if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
> - hw_error("register_ioport_write: invalid opaque");
> + hw_error("register_ioport_write: invalid opaque for 0x%x", i);
> ioport_opaque[i] = opaque;
> }
> return 0;
The idea looks good, but "for 0x%x" looks strange. Maybe something like
"for address 0x%x"?
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH v2] ioport: Improve error output
2011-01-20 11:48 ` Aurelien Jarno
@ 2011-03-06 14:48 ` Andreas Färber
2011-03-06 20:02 ` Aurelien Jarno
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2011-03-06 14:48 UTC (permalink / raw)
To: qemu-devel; +Cc: Andreas Färber, Aurelien Jarno
When failing due to conflicting I/O port registrations,
include the offending I/O port address in the message.
Cc: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
---
v2:
* Use "for address 0x%x" wording, as suggested by Aurelien.
ioport.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/ioport.c b/ioport.c
index aa4188a..2e971fa 100644
--- a/ioport.c
+++ b/ioport.c
@@ -149,7 +149,8 @@ int register_ioport_read(pio_addr_t start, int length, int size,
for(i = start; i < start + length; i += size) {
ioport_read_table[bsize][i] = func;
if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
- hw_error("register_ioport_read: invalid opaque");
+ hw_error("register_ioport_read: invalid opaque for address 0x%x",
+ i);
ioport_opaque[i] = opaque;
}
return 0;
@@ -168,7 +169,8 @@ int register_ioport_write(pio_addr_t start, int length, int size,
for(i = start; i < start + length; i += size) {
ioport_write_table[bsize][i] = func;
if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
- hw_error("register_ioport_write: invalid opaque");
+ hw_error("register_ioport_write: invalid opaque for address 0x%x",
+ i);
ioport_opaque[i] = opaque;
}
return 0;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] ioport: Improve error output
2011-03-06 14:48 ` [Qemu-devel] [PATCH v2] " Andreas Färber
@ 2011-03-06 20:02 ` Aurelien Jarno
0 siblings, 0 replies; 4+ messages in thread
From: Aurelien Jarno @ 2011-03-06 20:02 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-devel
On Sun, Mar 06, 2011 at 03:48:13PM +0100, Andreas Färber wrote:
> When failing due to conflicting I/O port registrations,
> include the offending I/O port address in the message.
>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> ---
> v2:
> * Use "for address 0x%x" wording, as suggested by Aurelien.
>
> ioport.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
Thanks, applied.
> diff --git a/ioport.c b/ioport.c
> index aa4188a..2e971fa 100644
> --- a/ioport.c
> +++ b/ioport.c
> @@ -149,7 +149,8 @@ int register_ioport_read(pio_addr_t start, int length, int size,
> for(i = start; i < start + length; i += size) {
> ioport_read_table[bsize][i] = func;
> if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
> - hw_error("register_ioport_read: invalid opaque");
> + hw_error("register_ioport_read: invalid opaque for address 0x%x",
> + i);
> ioport_opaque[i] = opaque;
> }
> return 0;
> @@ -168,7 +169,8 @@ int register_ioport_write(pio_addr_t start, int length, int size,
> for(i = start; i < start + length; i += size) {
> ioport_write_table[bsize][i] = func;
> if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
> - hw_error("register_ioport_write: invalid opaque");
> + hw_error("register_ioport_write: invalid opaque for address 0x%x",
> + i);
> ioport_opaque[i] = opaque;
> }
> return 0;
> --
> 1.7.3.4
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-06 20:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-27 0:00 [Qemu-devel] [PATCH] ioport: Improve error output Andreas Färber
2011-01-20 11:48 ` Aurelien Jarno
2011-03-06 14:48 ` [Qemu-devel] [PATCH v2] " Andreas Färber
2011-03-06 20:02 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).