From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42357 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PZnRC-00069d-Uu
	for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:39:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <glommer@redhat.com>) id 1PZnR9-0000bB-T8
	for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:39:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:9698)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <glommer@redhat.com>) id 1PZnR9-0000av-M0
	for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:39:11 -0500
From: Glauber Costa <glommer@redhat.com>
In-Reply-To: <4D21F9A3.6030404@web.de>
References: <cover.1294043582.git.jan.kiszka@web.de>
	<d35c17614fa7646ff48ef57f7922aec01e1044a6.1294043582.git.jan.kiszka@web.de>
	<4D21F3A5.1030905@redhat.com>  <4D21F9A3.6030404@web.de>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 03 Jan 2011 14:39:07 -0200
Message-ID: <1294072747.5370.24.camel@mothafucka.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 14/17] kvm: x86: Introduce kvmclock
 device to save/restore its state
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On Mon, 2011-01-03 at 17:30 +0100, Jan Kiszka wrote:
> Am 03.01.2011 17:04, Avi Kivity wrote:
> > On 01/03/2011 10:33 AM, Jan Kiszka wrote:
> >> From: Jan Kiszka<jan.kiszka@siemens.com>
> >>
> >> If kvmclock is used, which implies the kernel supports it, register a
> >> kvmclock device with the sysbus. Its main purpose is to save and restore
> >> the kernel state on migration, but this will also allow to visualize it
> >> one day.
> >>
> > 
> > kvmclock is a per-cpu affair.
> 
> Nope, it's state (the one save/restored here) is per VM.
> 
> > 
> >>
> >> @@ -534,6 +599,10 @@ int kvm_arch_init(int smp_cpus)
> >>       int ret;
> >>       struct utsname utsname;
> >>
> >> +#ifdef KVM_CAP_ADJUST_CLOCK
> >> +    sysbus_register_withprop(&kvmclock_info);
> >> +#endif
> >> +
> > 
> > So this doesn't look right.  I think we're fine with just migrating the
> > MSRs, like we migrate anything else that has to do with the cpu.
> > 
> 
> The kvmclock state is not contained in any MSR. It's an independent
> machine state that can be indirectly obtained via MSR access. Therefore,
> qemu-kvm currently registers only one vmstate entry per machine, and
> this patch just turns this into a clean device - because that's what
> kvmclock is in the end, something like an HPET.

Jan is right, the per-cpu information only cares about which piece of
memory will be written to.