* [Qemu-devel] [PATCH] multiboot: Fix upper memory size in multiboot info
@ 2011-01-04 13:03 Kevin Wolf
2011-01-23 21:51 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2011-01-04 13:03 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf
The upper memory size field should exclude the first MB of RAM.
Signed-off-by: Kevin Wolf <mail@kevin-wolf.de>
---
hw/multiboot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 7cc3055..0d2bfb4 100644
--- a/hw/multiboot.c
+++ b/hw/multiboot.c
@@ -306,7 +306,7 @@ int load_multiboot(void *fw_cfg,
| MULTIBOOT_FLAGS_MODULES
| MULTIBOOT_FLAGS_MMAP);
stl_p(bootinfo + MBI_MEM_LOWER, 640);
- stl_p(bootinfo + MBI_MEM_UPPER, ram_size / 1024);
+ stl_p(bootinfo + MBI_MEM_UPPER, (ram_size / 1024) - 1024);
stl_p(bootinfo + MBI_BOOT_DEVICE, 0x8001ffff); /* XXX: use the -boot switch? */
stl_p(bootinfo + MBI_MMAP_ADDR, ADDR_E820_MAP);
--
1.6.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] multiboot: Fix upper memory size in multiboot info
2011-01-04 13:03 [Qemu-devel] [PATCH] multiboot: Fix upper memory size in multiboot info Kevin Wolf
@ 2011-01-23 21:51 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2011-01-23 21:51 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
On Tue, Jan 04, 2011 at 02:03:30PM +0100, Kevin Wolf wrote:
> The upper memory size field should exclude the first MB of RAM.
>
> Signed-off-by: Kevin Wolf <mail@kevin-wolf.de>
> ---
> hw/multiboot.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/multiboot.c b/hw/multiboot.c
> index 7cc3055..0d2bfb4 100644
> --- a/hw/multiboot.c
> +++ b/hw/multiboot.c
> @@ -306,7 +306,7 @@ int load_multiboot(void *fw_cfg,
> | MULTIBOOT_FLAGS_MODULES
> | MULTIBOOT_FLAGS_MMAP);
> stl_p(bootinfo + MBI_MEM_LOWER, 640);
> - stl_p(bootinfo + MBI_MEM_UPPER, ram_size / 1024);
> + stl_p(bootinfo + MBI_MEM_UPPER, (ram_size / 1024) - 1024);
> stl_p(bootinfo + MBI_BOOT_DEVICE, 0x8001ffff); /* XXX: use the -boot switch? */
> stl_p(bootinfo + MBI_MMAP_ADDR, ADDR_E820_MAP);
>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-23 21:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-04 13:03 [Qemu-devel] [PATCH] multiboot: Fix upper memory size in multiboot info Kevin Wolf
2011-01-23 21:51 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).