qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>
Subject: [Qemu-devel] [PATCH 0/2] linux-user: fix incorrect NaN detection in ARM nwfpe emulation
Date: Thu,  6 Jan 2011 18:34:42 +0000	[thread overview]
Message-ID: <1294338884-20322-1-git-send-email-peter.maydell@linaro.org> (raw)

The code in the linux-user ARM nwfpe emulation was incorrectly checking only
for quiet NaNs when it should have been checking for any kind of NaN.  This
is probably because the code in question was taken from the Linux kernel,
whose copy of the softfloat library had been modified so that
float*_is_nan() returned true for all NaNs, not just quiet ones.  The qemu
equivalent function is float*_is_any_nan(), so use that.  NB that this code
is really obsolete since nobody uses FPE for actual arithmetic now; this is
just cleanup following the recent renaming of the NaN related functions.
(As such I have checked it against the equivalent Linux kernel code but
I don't have a test case for it.)

Peter Maydell (2):
  softfloat: Implement floatx80_is_any_nan() and float128_is_any_nan()
  linux-user: Fix incorrect NaN detection in ARM nwfpe emulation

 fpu/softfloat.h                   |   11 +++++++++++
 linux-user/arm/nwfpe/fpa11_cprt.c |   14 +++++++-------
 2 files changed, 18 insertions(+), 7 deletions(-)

             reply	other threads:[~2011-01-06 18:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06 18:34 Peter Maydell [this message]
2011-01-06 18:34 ` [Qemu-devel] [PATCH 1/2] softfloat: Implement floatx80_is_any_nan() and float128_is_any_nan() Peter Maydell
2011-01-07 15:28   ` Aurelien Jarno
2011-01-07 15:46     ` Peter Maydell
2011-01-06 18:34 ` [Qemu-devel] [PATCH 2/2] linux-user: Fix incorrect NaN detection in ARM nwfpe emulation Peter Maydell
2011-01-07 15:29   ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294338884-20322-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).