From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59564 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PbEty-0000Rf-6k
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 11:10:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PbEtx-0008LU-1c
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 11:10:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33908)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PbEtw-0008LM-OO
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 11:10:53 -0500
From: Alex Williamson <alex.williamson@redhat.com>
In-Reply-To: <4D273965.1090609@web.de>
References: <20110107071815.26658.403.stgit@s20.home>
	<20110107155817.12891.70829.stgit@s20.home> <4D273965.1090609@web.de>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 07 Jan 2011 09:10:50 -0700
Message-ID: <1294416650.3214.9.camel@x201>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH V2] savevm: use error_report for
	vmstate_save error
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org, quintela@redhat.com

On Fri, 2011-01-07 at 17:03 +0100, Jan Kiszka wrote:
> Am 07.01.2011 16:58, Alex Williamson wrote:
> > If migration is done in the background with the -d option, mon is
> > NULL and this error message is lost.  Instead use error_report().
> > 
> > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> 
> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
> 
> As already at it: Is this the only error during migration that can get
> lost this way?

On the migration source side, I think so.  All the save callbacks are
return void, so device saves aren't allow to fail.  The unmigratable
device registration is the only way I know to trigger an error on this
end.  Thanks,

Alex

> > ---
> > 
> >  savevm.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/savevm.c b/savevm.c
> > index 90aa237..148871d 100644
> > --- a/savevm.c
> > +++ b/savevm.c
> > @@ -1543,7 +1543,7 @@ int qemu_savevm_state_complete(Monitor *mon, QEMUFile *f)
> >  
> >          r = vmstate_save(f, se);
> >          if (r < 0) {
> > -            monitor_printf(mon, "cannot migrate with device '%s'\n", se->idstr);
> > +            error_report("cannot migrate with device '%s'\n", se->idstr);
> >              return r;
> >          }
> >      }
> > 
> 
>