From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59605 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PbHFJ-0000fv-Sz
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 13:41:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PbHFI-0003wX-Hw
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 13:41:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50419)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PbHFI-0003wH-6b
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 13:41:04 -0500
From: Alex Williamson <alex.williamson@redhat.com>
In-Reply-To: <4D273EDE.1070003@web.de>
References: <20110107071815.26658.403.stgit@s20.home>
	<20110107155817.12891.70829.stgit@s20.home> <4D273965.1090609@web.de>
	<1294416650.3214.9.camel@x201>  <4D273EDE.1070003@web.de>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 07 Jan 2011 11:41:01 -0700
Message-ID: <1294425661.3214.12.camel@x201>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH V2] savevm: use error_report for
	vmstate_save error
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org, quintela@redhat.com

On Fri, 2011-01-07 at 17:27 +0100, Jan Kiszka wrote:
> Am 07.01.2011 17:10, Alex Williamson wrote:
> > On Fri, 2011-01-07 at 17:03 +0100, Jan Kiszka wrote:
> >> Am 07.01.2011 16:58, Alex Williamson wrote:
> >>> If migration is done in the background with the -d option, mon is
> >>> NULL and this error message is lost.  Instead use error_report().
> >>>
> >>> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> >>
> >> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> As already at it: Is this the only error during migration that can get
> >> lost this way?
> > 
> > On the migration source side, I think so.  All the save callbacks are
> > return void, so device saves aren't allow to fail.  The unmigratable
> > device registration is the only way I know to trigger an error on this
> > end.  Thanks,
> 
> Hmm, thinking about this again, wouldn't it be a better user experience
> to check this in advance, at a time where the issuing console is still
> listening?

I hope v3 addresses this as you were hoping.  It also fixes a couple
other issues with no_migrate.  Thanks,

Alex