From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46606 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcJ6i-0000Z7-V2 for qemu-devel@nongnu.org; Mon, 10 Jan 2011 09:52:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcJ6h-0004Or-Vj for qemu-devel@nongnu.org; Mon, 10 Jan 2011 09:52:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PcJ6h-0004OY-Oy for qemu-devel@nongnu.org; Mon, 10 Jan 2011 09:52:27 -0500 From: Alex Williamson In-Reply-To: <20110110102450.GA2723@redhat.com> References: <20110107183518.13483.52633.stgit@s20.home> <20110107220801.15395.38757.stgit@s20.home> <20110110102450.GA2723@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 10 Jan 2011 07:52:24 -0700 Message-ID: <1294671144.3214.35.camel@x201> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v4] savevm: Fix no_migrate List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: mst@redhat.com, jan.kiszka@web.de, qemu-devel@nongnu.org, quintela@redhat.com On Mon, 2011-01-10 at 10:24 +0000, Daniel P. Berrange wrote: > On Fri, Jan 07, 2011 at 03:13:25PM -0700, Alex Williamson wrote: > > The no_migrate save state flag is currently only checked in the > > last phase of migration. This means that we potentially waste > > a lot of time and bandwidth with the live state handlers before > > we ever check the no_migrate flags. The error message printed > > when we catch a non-migratable device doesn't get printed for > > a detached migration. And, no_migrate does nothing to prevent > > an incoming migration to a target that includes a non-migratable > > device. This attempts to fix all of these. > > > > One notable difference in behavior is that an outgoing migration > > now checks for non-migratable devices before ever connecting to > > the target system. This means the target will remain listening > > rather than exit from failure. > > > > Signed-off-by: Alex Williamson > > --- > > > > v4: > > - fix braces noted by Jan > > - return error from qemu_savevm_state_blocked rather than fixed EINVAL > > at qemu_loadvm_state(), since it'a already using errno values > > > > v3: > > > > Daniel, adding you to see if libvirt cares about the difference in > > whether the target exits on migration failure as noted above. > > If the 'migrate' command on the source QEMU returns an error, > then libvirt will teardown the target QEMU automatically, so > that's not a problem. Thanks, that's the way I was hoping it would work. Alex