* [Qemu-devel] [PATCH] qemu-img snapshot: Use writeback caching
@ 2011-01-10 16:54 Kevin Wolf
2011-01-10 21:53 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2011-01-10 16:54 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf
None of the other qemu-img subcommands uses writethrough, and there's no reason
why snapshot should be special.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
qemu-img.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index afd9ed2..1e65ea8 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1068,7 +1068,7 @@ static int img_snapshot(int argc, char **argv)
int action = 0;
qemu_timeval tv;
- bdrv_oflags = BDRV_O_RDWR;
+ bdrv_oflags = BDRV_O_FLAGS | BDRV_O_RDWR;
/* Parse commandline parameters */
for(;;) {
c = getopt(argc, argv, "la:c:d:h");
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-img snapshot: Use writeback caching
2011-01-10 16:54 [Qemu-devel] [PATCH] qemu-img snapshot: Use writeback caching Kevin Wolf
@ 2011-01-10 21:53 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2011-01-10 21:53 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
On Mon, Jan 10, 2011 at 4:54 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> None of the other qemu-img subcommands uses writethrough, and there's no reason
> why snapshot should be special.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qemu-img.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-10 22:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-10 16:54 [Qemu-devel] [PATCH] qemu-img snapshot: Use writeback caching Kevin Wolf
2011-01-10 21:53 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).