From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45849 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcKzI-0002XW-OO for qemu-devel@nongnu.org; Mon, 10 Jan 2011 11:53:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcKzF-0006Xh-4s for qemu-devel@nongnu.org; Mon, 10 Jan 2011 11:52:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PcKzE-0006XN-Ty for qemu-devel@nongnu.org; Mon, 10 Jan 2011 11:52:53 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0AGqqrT028309 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 10 Jan 2011 11:52:52 -0500 From: Kevin Wolf Date: Mon, 10 Jan 2011 17:54:20 +0100 Message-Id: <1294678460-7492-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] qemu-img snapshot: Use writeback caching List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com None of the other qemu-img subcommands uses writethrough, and there's no reason why snapshot should be special. Signed-off-by: Kevin Wolf --- qemu-img.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index afd9ed2..1e65ea8 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1068,7 +1068,7 @@ static int img_snapshot(int argc, char **argv) int action = 0; qemu_timeval tv; - bdrv_oflags = BDRV_O_RDWR; + bdrv_oflags = BDRV_O_FLAGS | BDRV_O_RDWR; /* Parse commandline parameters */ for(;;) { c = getopt(argc, argv, "la:c:d:h"); -- 1.7.2.3