* [Qemu-devel] [PATCH] qdev: Fix printout of bit device properties with bit index >= 8
@ 2011-01-10 22:11 digit
2011-01-11 9:23 ` Markus Armbruster
2011-02-20 17:54 ` Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: digit @ 2011-01-10 22:11 UTC (permalink / raw)
To: qemu-devel; +Cc: David 'Digit' Turner
From: David 'Digit' Turner <digit@google.com>
Signed-off-by: David 'Digit' Turner <digit@google.com>
---
hw/qdev-properties.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 9219cd7..d5d9591 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -50,7 +50,7 @@ static int parse_bit(DeviceState *dev, Property *prop, const char *str)
static int print_bit(DeviceState *dev, Property *prop, char *dest, size_t len)
{
- uint8_t *p = qdev_get_prop_ptr(dev, prop);
+ uint32_t *p = qdev_get_prop_ptr(dev, prop);
return snprintf(dest, len, (*p & qdev_get_prop_mask(prop)) ? "on" : "off");
}
--
1.7.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qdev: Fix printout of bit device properties with bit index >= 8
2011-01-10 22:11 [Qemu-devel] [PATCH] qdev: Fix printout of bit device properties with bit index >= 8 digit
@ 2011-01-11 9:23 ` Markus Armbruster
2011-02-20 17:54 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2011-01-11 9:23 UTC (permalink / raw)
To: digit; +Cc: qemu-devel
digit@google.com writes:
> From: David 'Digit' Turner <digit@google.com>
>
> Signed-off-by: David 'Digit' Turner <digit@google.com>
> ---
> hw/qdev-properties.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> index 9219cd7..d5d9591 100644
> --- a/hw/qdev-properties.c
> +++ b/hw/qdev-properties.c
> @@ -50,7 +50,7 @@ static int parse_bit(DeviceState *dev, Property *prop, const char *str)
>
> static int print_bit(DeviceState *dev, Property *prop, char *dest, size_t len)
> {
> - uint8_t *p = qdev_get_prop_ptr(dev, prop);
> + uint32_t *p = qdev_get_prop_ptr(dev, prop);
> return snprintf(dest, len, (*p & qdev_get_prop_mask(prop)) ? "on" : "off");
> }
Acked-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qdev: Fix printout of bit device properties with bit index >= 8
2011-01-10 22:11 [Qemu-devel] [PATCH] qdev: Fix printout of bit device properties with bit index >= 8 digit
2011-01-11 9:23 ` Markus Armbruster
@ 2011-02-20 17:54 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2011-02-20 17:54 UTC (permalink / raw)
To: digit; +Cc: qemu-devel
On Mon, Jan 10, 2011 at 11:11:40PM +0100, digit@google.com wrote:
> From: David 'Digit' Turner <digit@google.com>
>
> Signed-off-by: David 'Digit' Turner <digit@google.com>
> ---
> hw/qdev-properties.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> index 9219cd7..d5d9591 100644
> --- a/hw/qdev-properties.c
> +++ b/hw/qdev-properties.c
> @@ -50,7 +50,7 @@ static int parse_bit(DeviceState *dev, Property *prop, const char *str)
>
> static int print_bit(DeviceState *dev, Property *prop, char *dest, size_t len)
> {
> - uint8_t *p = qdev_get_prop_ptr(dev, prop);
> + uint32_t *p = qdev_get_prop_ptr(dev, prop);
> return snprintf(dest, len, (*p & qdev_get_prop_mask(prop)) ? "on" : "off");
> }
>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-20 17:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-10 22:11 [Qemu-devel] [PATCH] qdev: Fix printout of bit device properties with bit index >= 8 digit
2011-01-11 9:23 ` Markus Armbruster
2011-02-20 17:54 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).