From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 4/8] target-arm: Translate with VFP len/stride from TB flags, not CPUState
Date: Tue, 11 Jan 2011 22:12:14 +0000 [thread overview]
Message-ID: <1294783938-19629-5-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1294783938-19629-1-git-send-email-peter.maydell@linaro.org>
When translating, the VFP vector length and stride for this TB are encoded
in the TB flags; the CPUState copies may be different and must not be used.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target-arm/translate.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 9e0b0b1..624a443 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -60,6 +60,8 @@ typedef struct DisasContext {
int user;
#endif
int vfp_enabled;
+ int vec_len;
+ int vec_stride;
} DisasContext;
#if defined(CONFIG_USER_ONLY)
@@ -2895,7 +2897,7 @@ static int disas_vfp_insn(CPUState * env, DisasContext *s, uint32_t insn)
rm = VFP_SREG_M(insn);
}
- veclen = env->vfp.vec_len;
+ veclen = s->vec_len;
if (op == 15 && rn > 3)
veclen = 0;
@@ -2916,9 +2918,9 @@ static int disas_vfp_insn(CPUState * env, DisasContext *s, uint32_t insn)
veclen = 0;
} else {
if (dp)
- delta_d = (env->vfp.vec_stride >> 1) + 1;
+ delta_d = (s->vec_stride >> 1) + 1;
else
- delta_d = env->vfp.vec_stride + 1;
+ delta_d = s->vec_stride + 1;
if ((rm & bank_mask) == 0) {
/* mixed scalar/vector */
@@ -9083,6 +9085,8 @@ static inline void gen_intermediate_code_internal(CPUState *env,
}
#endif
dc->vfp_enabled = ARM_TBFLAG_VFPEN(tb->flags);
+ dc->vec_len = ARM_TBFLAG_VECLEN(tb->flags);
+ dc->vec_stride = ARM_TBFLAG_VECSTRIDE(tb->flags);
cpu_F0s = tcg_temp_new_i32();
cpu_F1s = tcg_temp_new_i32();
cpu_F0d = tcg_temp_new_i64();
--
1.6.3.3
next prev parent reply other threads:[~2011-01-11 22:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 22:12 [Qemu-devel] [PATCH v2 0/8] target-arm: Translate based on TB flags, not CPUState Peter Maydell
2011-01-11 22:12 ` [Qemu-devel] [PATCH 1/8] target-arm: Don't generate code specific to current CPU mode for SRS Peter Maydell
2011-01-12 10:21 ` Aurelien Jarno
2011-01-11 22:12 ` [Qemu-devel] [PATCH 2/8] target-arm: Add symbolic constants for bitfields in TB flags Peter Maydell
2011-01-12 10:21 ` Aurelien Jarno
2011-01-11 22:12 ` [Qemu-devel] [PATCH 3/8] target-arm: Translate with VFP-enabled from TB flags, not CPUState Peter Maydell
2011-01-12 10:21 ` Aurelien Jarno
2011-01-11 22:12 ` Peter Maydell [this message]
2011-01-12 10:21 ` [Qemu-devel] [PATCH 4/8] target-arm: Translate with VFP len/stride " Aurelien Jarno
2011-01-11 22:12 ` [Qemu-devel] [PATCH 5/8] target-arm: Translate with Thumb state " Peter Maydell
2011-01-12 10:21 ` Aurelien Jarno
2011-01-11 22:12 ` [Qemu-devel] [PATCH 6/8] target-arm: Translate with condexec bits " Peter Maydell
2011-01-12 10:22 ` Aurelien Jarno
2011-01-11 22:12 ` [Qemu-devel] [PATCH 7/8] target-arm: Set privileged bit in TB flags correctly for M profile Peter Maydell
2011-01-12 10:22 ` Aurelien Jarno
2011-01-11 22:12 ` [Qemu-devel] [PATCH 8/8] target-arm: Translate with user-state from TB flags, not CPUState Peter Maydell
2011-01-12 10:22 ` Aurelien Jarno
2011-01-14 19:40 ` [Qemu-devel] [PATCH v2 0/8] target-arm: Translate based on " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294783938-19629-5-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).