From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-devel@nongnu.orgqemu-devel@nongnu.org
Cc: Michael Tokarev <mjt@tls.msk.ru>
Subject: [Qemu-devel] [PATCH 1/3] make path_has_protocol() to return pointer instead of bool
Date: Wed, 12 Jan 2011 13:57:00 +0300 [thread overview]
Message-ID: <1294829822-27938-2-git-send-email-mjt@msgid.tls.msk.ru> (raw)
In-Reply-To: <1294829822-27938-1-git-send-email-mjt@tls.msk.ru>
Currently protocol: parsing in filenames is ad-hoc and scattered all around
block.c. This is a first step to prepare for common parsing.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
block.c | 18 +++++++++++++++---
1 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index ff2795b..e5a6f60 100644
--- a/block.c
+++ b/block.c
@@ -90,9 +90,11 @@ int is_windows_drive(const char *filename)
}
#endif
-/* check if the path starts with "<protocol>:" */
-static int path_has_protocol(const char *path)
+/* check if the path starts with "<protocol>:"
+ * Return pointer to the leading colon or NULL */
+static char *path_has_protocol(const char *path)
{
+ const char *p;
#ifdef _WIN32
if (is_windows_drive(path) ||
is_windows_drive_prefix(path)) {
@@ -100,7 +102,17 @@ static int path_has_protocol(const char *path)
}
#endif
- return strchr(path, ':') != NULL;
+ p = path;
+ /* we allow [a-z_] for now */
+ while((*p >= 'a' && *p <= 'z') || *p == '_') {
+ ++p;
+ }
+
+#define MAX_PROTO_LEN 31
+ /* recognize non-empty string of max MAX_PROTO chars as protocol */
+ return
+ *p == ':' && p > path && (p - path) <= MAX_PROTO_LEN ?
+ (char*)p : NULL;
}
int path_is_absolute(const char *path)
--
1.7.2.3
next parent reply other threads:[~2011-01-12 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1294829822-27938-1-git-send-email-mjt@tls.msk.ru>
2011-01-12 10:57 ` Michael Tokarev [this message]
2011-01-21 9:29 ` [Qemu-devel] [PATCH 1/3] make path_has_protocol() to return pointer instead of bool Kevin Wolf
2011-01-12 10:57 ` [Qemu-devel] [PATCH 2/3] use new path_has_protocol() in bdrv_find_protocol() Michael Tokarev
2011-01-12 10:57 ` [Qemu-devel] [PATCH 3/3] make path_combine() especially for filenames, not URLs Michael Tokarev
2011-01-21 10:07 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294829822-27938-2-git-send-email-mjt@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.orgqemu-devel \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).