From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58298 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PdsR6-0004aa-LS for qemu-devel@nongnu.org; Fri, 14 Jan 2011 17:48:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PdsO9-0006d8-R4 for qemu-devel@nongnu.org; Fri, 14 Jan 2011 17:44:58 -0500 Received: from mtagate6.uk.ibm.com ([194.196.100.166]:51507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PdsO9-0006ch-Ia for qemu-devel@nongnu.org; Fri, 14 Jan 2011 17:44:57 -0500 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate6.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p0EMisGQ003339 for ; Fri, 14 Jan 2011 22:44:54 GMT Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0EMipgs1081540 for ; Fri, 14 Jan 2011 22:44:57 GMT Received: from d06av08.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0EMim7w008504 for ; Fri, 14 Jan 2011 22:44:48 GMT From: Stefan Hajnoczi Date: Fri, 14 Jan 2011 22:44:33 +0000 Message-Id: <1295045073-17529-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH] qed: Refuse to create images on block devices List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi QED relies on the underlying filesystem to extend the file and maintain its size. Check that images are not created on a block device. Signed-off-by: Stefan Hajnoczi --- block/qed.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/block/qed.c b/block/qed.c index 085c4f2..a46f9ef 100644 --- a/block/qed.c +++ b/block/qed.c @@ -469,6 +469,12 @@ static int qed_create(const char *filename, uint32_t cluster_size, return ret; } + /* File must start empty and grow, check truncate is supported */ + ret = bdrv_truncate(bs, 0); + if (ret < 0) { + goto out; + } + if (backing_file) { header.features |= QED_F_BACKING_FILE; header.backing_filename_offset = sizeof(le_header); -- 1.7.2.3