From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51448 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PeXjV-0005vF-1H for qemu-devel@nongnu.org; Sun, 16 Jan 2011 13:53:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PeXjT-0005KN-RW for qemu-devel@nongnu.org; Sun, 16 Jan 2011 13:53:44 -0500 Received: from hall.aurel32.net ([88.191.126.93]:33197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PeXjT-0005KF-Lk for qemu-devel@nongnu.org; Sun, 16 Jan 2011 13:53:43 -0500 From: Aurelien Jarno Date: Sun, 16 Jan 2011 19:53:40 +0100 Message-Id: <1295204020-12669-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH] usb-hid: modifiers should generate an event List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno When a modifier key is pressed or released, the USB HID keyboard still answers NAK, unless another key is also pressed or released. The patch fixes that by calling usb_hid_changed() when a modifier key is pressed or released. Signed-off-by: Aurelien Jarno --- hw/usb-hid.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c index e8de301..12bf46f 100644 --- a/hw/usb-hid.c +++ b/hw/usb-hid.c @@ -460,15 +460,18 @@ static void usb_keyboard_event(void *opaque, int keycode) case 0xe0: if (s->modifiers & (1 << 9)) { s->modifiers ^= 3 << 8; + usb_hid_changed(hs); return; } case 0xe1 ... 0xe7: if (keycode & (1 << 7)) { s->modifiers &= ~(1 << (hid_code & 0x0f)); + usb_hid_changed(hs); return; } case 0xe8 ... 0xef: s->modifiers |= 1 << (hid_code & 0x0f); + usb_hid_changed(hs); return; } -- 1.7.2.3