From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35982 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Peqwd-00007p-Su
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 10:24:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PeqwZ-00022y-FA
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 10:24:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40756)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PeqwZ-00022l-7n
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 10:24:31 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0HFOS9r028527
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 17 Jan 2011 10:24:29 -0500
From: Alex Williamson <alex.williamson@redhat.com>
In-Reply-To: <1295277257-17425-1-git-send-email-Jes.Sorensen@redhat.com>
References: <1295277257-17425-1-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 17 Jan 2011 08:24:27 -0700
Message-ID: <1295277867.3216.16.camel@x201>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 0/2] strtosz() cleanup
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: kwolf@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org

On Mon, 2011-01-17 at 16:14 +0100, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> 
> Fix issue with signed char and isspace() as well as clean up switch
> statement using toupper().
> 
> V2 of the patch fixes some types in the commit messages and spells
> Eric correctly. My apologies for getting it wrong.
> 
> Jes Sorensen (2):
>   strtosz() use unsigned char as isspace() is not defined for signed
>     char
>   strtosz() use toupper() to simplify switch statement
> 
>  cutils.c |   10 +++-------
>  1 files changed, 3 insertions(+), 7 deletions(-)
> 

And the modf() usage?  Or using STRTOSZ_DEFSUFFIX_* in the switch?  Or
avoiding the extra variable in 13/18?  Thanks,

Alex