From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <hch@lst.de>,
"Justin M. Forbes" <jforbes@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/3] usb-msd: Add usb-storage, removable=on|off property
Date: Tue, 18 Jan 2011 10:10:39 +0000 [thread overview]
Message-ID: <1295345442-16218-1-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
Allow overriding the SCSI INQUIRY removable (RMB) bit for scsi-disk and usb-msd
devices. In particular this addresses the problem that some usb-msd devices
have the bit set while other do not have it set. Now the user can choose and
get desired guest behavior.
qemu -usb
-drive if=none,file=test.img,cache=none,id=disk0
-device usb-storage,drive=disk0,removable=on
The default is off.
v2:
* Rewritten to override the bit at the scsi-disk level
hw/pci-hotplug.c | 2 +-
hw/scsi-bus.c | 8 ++++++--
hw/scsi-disk.c | 3 +++
hw/scsi.h | 3 ++-
hw/usb-msd.c | 4 +++-
5 files changed, 15 insertions(+), 5 deletions(-)
next reply other threads:[~2011-01-18 10:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 10:10 Stefan Hajnoczi [this message]
2011-01-18 10:10 ` [Qemu-devel] [PATCH v2 1/3] scsi-disk: Allow overriding SCSI INQUIRY removable bit Stefan Hajnoczi
2011-01-18 11:39 ` Kevin Wolf
2011-01-18 12:06 ` Stefan Hajnoczi
2011-01-21 10:45 ` Stefan Hajnoczi
2011-01-21 11:09 ` Kevin Wolf
2011-01-21 17:38 ` Markus Armbruster
2011-01-18 10:10 ` [Qemu-devel] [PATCH v2 2/3] scsi: Allow SCSI devices to override the " Stefan Hajnoczi
2011-01-18 10:10 ` [Qemu-devel] [PATCH v2 3/3] usb-msd: Propagate removable bit to SCSI device Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295345442-16218-1-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=jforbes@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).