From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58057 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pf9HB-0007of-5b for qemu-devel@nongnu.org; Tue, 18 Jan 2011 06:03:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pf9Gv-00061m-D0 for qemu-devel@nongnu.org; Tue, 18 Jan 2011 05:58:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pf9Gv-00061Q-50 for qemu-devel@nongnu.org; Tue, 18 Jan 2011 05:58:45 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0IAwi1c010755 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 18 Jan 2011 05:58:44 -0500 Received: from playa.tlv.redhat.com (dhcp-3-210.tlv.redhat.com [10.35.3.210]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p0IAwfYY027054 for ; Tue, 18 Jan 2011 05:58:43 -0500 From: Alon Levy Date: Tue, 18 Jan 2011 12:58:38 +0200 Message-Id: <1295348320-32099-2-git-send-email-alevy@redhat.com> In-Reply-To: <1295348320-32099-1-git-send-email-alevy@redhat.com> References: <1295348320-32099-1-git-send-email-alevy@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] qdev: add print_options callback List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org another callback added to PropertyInfo, for later use by PROP_TYPE_ENUM. Allows printing of runtime computed options when doing: qemu -device foo,? --- hw/qdev.c | 10 +++++++++- hw/qdev.h | 1 + 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 5b8d374..d1550b9 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -188,7 +188,15 @@ int qdev_device_help(QemuOpts *opts) if (!prop->info->parse) { continue; /* no way to set it, don't show */ } - error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name); + if (prop->info->print_options) { + char buf[256]; + int ret; + ret = prop->info->print_options(info, prop, buf, sizeof(buf) - 3); + error_printf("%s.%s=%s%s\n", info->name, prop->name, buf, + ret == sizeof(buf) - 3 ? "..." : "" ); + } else { + error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name); + } } return 1; } diff --git a/hw/qdev.h b/hw/qdev.h index e520aaa..530fc5d 100644 --- a/hw/qdev.h +++ b/hw/qdev.h @@ -109,6 +109,7 @@ struct PropertyInfo { enum PropertyType type; int (*parse)(DeviceState *dev, Property *prop, const char *str); int (*print)(DeviceState *dev, Property *prop, char *dest, size_t len); + int (*print_options)(DeviceInfo *info, Property *prop, char *dest, size_t len); void (*free)(DeviceState *dev, Property *prop); }; -- 1.7.3.4