From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <hch@lst.de>,
"Justin M. Forbes" <jforbes@redhat.com>
Subject: [Qemu-devel] [PATCH v3 0/4] usb-msd: Add usb-storage, removable=on|off property
Date: Fri, 21 Jan 2011 11:00:05 +0000 [thread overview]
Message-ID: <1295607609-21091-1-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
Allow overriding the SCSI INQUIRY removable (RMB) bit for scsi-disk and usb-msd
devices. In particular this addresses the problem that some usb-msd devices
have the bit set while other do not have it set. Now the user can choose and
get desired guest behavior.
qemu -usb
-drive if=none,file=test.img,cache=none,id=disk0
-device usb-storage,drive=disk0,removable=on
The default is off.
v3:
* Document removable property in qdev-device-use.txt
* Use bit number 0 instead of bit 1 for the qdev property
v2:
* Rewritten to override the bit at the scsi-disk level
docs/qdev-device-use.txt | 13 +++++++++++--
hw/pci-hotplug.c | 2 +-
hw/scsi-bus.c | 8 ++++++--
hw/scsi-disk.c | 3 +++
hw/scsi.h | 3 ++-
hw/usb-msd.c | 4 +++-
6 files changed, 26 insertions(+), 7 deletions(-)
next reply other threads:[~2011-01-21 11:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 11:00 Stefan Hajnoczi [this message]
2011-01-21 11:00 ` [Qemu-devel] [PATCH v3 1/4] scsi-disk: Allow overriding SCSI INQUIRY removable bit Stefan Hajnoczi
2011-01-21 11:00 ` [Qemu-devel] [PATCH v3 2/4] scsi: Allow SCSI devices to override the " Stefan Hajnoczi
2011-01-21 17:26 ` Markus Armbruster
2011-01-24 14:47 ` Stefan Hajnoczi
2011-01-21 11:00 ` [Qemu-devel] [PATCH v3 3/4] usb-msd: Propagate removable bit to SCSI device Stefan Hajnoczi
2011-01-21 11:00 ` [Qemu-devel] [PATCH v3 4/4] docs: Document scsi-disk and usb-storage removable parameter Stefan Hajnoczi
2011-01-21 12:28 ` [Qemu-devel] Re: [PATCH v3 0/4] usb-msd: Add usb-storage, removable=on|off property Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295607609-21091-1-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=jforbes@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).