* [Qemu-devel] [PATCH] qemu-char: Check for missing backend name
@ 2011-01-22 13:07 Stefan Hajnoczi
2011-02-20 17:27 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hajnoczi @ 2011-01-22 13:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori, Stefan Hajnoczi
Check if the backend option is missing before searching the backend
table. This fixes a NULL pointer dereference when QEMU is invoked with
the following invalid command-line:
$ qemu -chardev id=foo,path=/tmp/socket
Previously QEMU would segfault, now it produces this error message:
chardev: "foo" missing backend
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
qemu-char.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index edc9ad6..8a424d6 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2508,6 +2508,11 @@ CharDriverState *qemu_chr_open_opts(QemuOpts *opts,
return NULL;
}
+ if (qemu_opt_get(opts, "backend") == NULL) {
+ fprintf(stderr, "chardev: \"%s\" missing backend\n",
+ qemu_opts_id(opts));
+ return NULL;
+ }
for (i = 0; i < ARRAY_SIZE(backend_table); i++) {
if (strcmp(backend_table[i].name, qemu_opt_get(opts, "backend")) == 0)
break;
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-char: Check for missing backend name
2011-01-22 13:07 [Qemu-devel] [PATCH] qemu-char: Check for missing backend name Stefan Hajnoczi
@ 2011-02-20 17:27 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2011-02-20 17:27 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Anthony Liguori, qemu-devel
On Sat, Jan 22, 2011 at 01:07:26PM +0000, Stefan Hajnoczi wrote:
> Check if the backend option is missing before searching the backend
> table. This fixes a NULL pointer dereference when QEMU is invoked with
> the following invalid command-line:
>
> $ qemu -chardev id=foo,path=/tmp/socket
>
> Previously QEMU would segfault, now it produces this error message:
>
> chardev: "foo" missing backend
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
> qemu-char.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
Thanks, applied.
> diff --git a/qemu-char.c b/qemu-char.c
> index edc9ad6..8a424d6 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2508,6 +2508,11 @@ CharDriverState *qemu_chr_open_opts(QemuOpts *opts,
> return NULL;
> }
>
> + if (qemu_opt_get(opts, "backend") == NULL) {
> + fprintf(stderr, "chardev: \"%s\" missing backend\n",
> + qemu_opts_id(opts));
> + return NULL;
> + }
> for (i = 0; i < ARRAY_SIZE(backend_table); i++) {
> if (strcmp(backend_table[i].name, qemu_opt_get(opts, "backend")) == 0)
> break;
> --
> 1.7.2.3
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-20 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-22 13:07 [Qemu-devel] [PATCH] qemu-char: Check for missing backend name Stefan Hajnoczi
2011-02-20 17:27 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).