From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38445 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PhORz-0000uH-Ld
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 10:35:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1PhORw-00022k-62
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 10:35:26 -0500
Received: from mtagate7.uk.ibm.com ([194.196.100.167]:46873)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1PhORv-00022W-Qs
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 10:35:24 -0500
Received: from d06nrmr1507.portsmouth.uk.ibm.com
	(d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233])
	by mtagate7.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p0OFZKpZ013771
	for <qemu-devel@nongnu.org>; Mon, 24 Jan 2011 15:35:20 GMT
Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com
	[9.149.37.249])
	by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id p0OFZMBh1306726
	for <qemu-devel@nongnu.org>; Mon, 24 Jan 2011 15:35:22 GMT
Received: from d06av08.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av08.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id p0OFZJQI021767
	for <qemu-devel@nongnu.org>; Mon, 24 Jan 2011 15:35:19 GMT
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Date: Mon, 24 Jan 2011 15:34:57 +0000
Message-Id: <1295883301-7278-1-git-send-email-stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v4 0/4] usb-msd: Add usb-storage,
	removable=on|off property
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <hch@lst.de>, "Justin M. Forbes" <jforbes@redhat.com>, Markus Armbruster <armbru@redhat.com>

Allow overriding the SCSI INQUIRY removable (RMB) bit for scsi-disk and usb-msd
devices.  In particular this addresses the problem that some usb-msd devices
have the bit set while other do not have it set.  Now the user can choose and
get desired guest behavior.

qemu -usb
    -drive if=none,file=test.img,cache=none,id=disk0
    -device usb-storage,drive=disk0,removable=on

The default is off.

v4:
 * Explicitly state that scsi-generic does not support the removable bit override
 * Try to make the scsi_bus_legacy_add_drive() commit description clearer

v3:
 * Document removable property in qdev-device-use.txt
 * Use bit number 0 instead of bit 1 for the qdev property

v2:
 * Rewritten to override the bit at the scsi-disk level