From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38333 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhTdx-0008Vn-61 for qemu-devel@nongnu.org; Mon, 24 Jan 2011 16:08:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhTdj-0006lv-GX for qemu-devel@nongnu.org; Mon, 24 Jan 2011 16:07:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhTdj-0006lP-9B for qemu-devel@nongnu.org; Mon, 24 Jan 2011 16:07:55 -0500 From: Gerd Hoffmann Date: Mon, 24 Jan 2011 22:07:45 +0100 Message-Id: <1295903266-6458-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1295903266-6458-1-git-send-email-kraxel@redhat.com> References: <1295903266-6458-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [RESEND PATCH 2/3] pulseaudio: setup buffer attrs List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Request reasonable buffer sizes from pulseaudio. Without this pa_simple_write() can block quite long and lead to dropouts, especially with guests which use small audio ring buffers. Signed-off-by: Gerd Hoffmann --- audio/paaudio.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 858ca81..75e3ea0 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -289,6 +289,7 @@ static int qpa_init_out (HWVoiceOut *hw, struct audsettings *as) { int error; static pa_sample_spec ss; + static pa_buffer_attr ba; struct audsettings obt_as = *as; PAVoiceOut *pa = (PAVoiceOut *) hw; @@ -296,6 +297,15 @@ static int qpa_init_out (HWVoiceOut *hw, struct audsettings *as) ss.channels = as->nchannels; ss.rate = as->freq; + /* + * qemu audio tick runs at 250 Hz (by default), so processing + * data chunks worth 4 ms of sound should be a good fit. + */ + ba.tlength = pa_usec_to_bytes (4 * 1000, &ss); + ba.minreq = pa_usec_to_bytes (2 * 1000, &ss); + ba.maxlength = -1; + ba.prebuf = -1; + obt_as.fmt = pa_to_audfmt (ss.format, &obt_as.endianness); pa->s = pa_simple_new ( @@ -306,7 +316,7 @@ static int qpa_init_out (HWVoiceOut *hw, struct audsettings *as) "pcm.playback", &ss, NULL, /* channel map */ - NULL, /* buffering attributes */ + &ba, /* buffering attributes */ &error ); if (!pa->s) { -- 1.7.1