From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60757 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhTfl-00016P-N6 for qemu-devel@nongnu.org; Mon, 24 Jan 2011 16:10:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhTfj-0007Rx-C1 for qemu-devel@nongnu.org; Mon, 24 Jan 2011 16:10:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhTfj-0007Rm-14 for qemu-devel@nongnu.org; Mon, 24 Jan 2011 16:09:59 -0500 From: Kevin Wolf Date: Mon, 24 Jan 2011 22:10:41 +0100 Message-Id: <1295903452-18017-13-git-send-email-kwolf@redhat.com> In-Reply-To: <1295903452-18017-1-git-send-email-kwolf@redhat.com> References: <1295903452-18017-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 12/23] ide: Remove unneeded null pointer check List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Weil With bm == NULL, other code in the same function would crash. This bug was reported by cppcheck: hw/ide/pci.c:280: error: Possible null pointer dereference: bm Cc: Michael S. Tsirkin Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf --- hw/ide/pci.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index 987caff..35168cb 100644 --- a/hw/ide/pci.c +++ b/hw/ide/pci.c @@ -267,9 +267,7 @@ static void bmdma_irq(void *opaque, int n, int level) return; } - if (bm) { - bm->status |= BM_STATUS_INT; - } + bm->status |= BM_STATUS_INT; /* trigger the real irq */ qemu_set_irq(bm->irq, level); -- 1.7.2.3