From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60818 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhTfq-000195-Uc for qemu-devel@nongnu.org; Mon, 24 Jan 2011 16:10:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhTfn-0007U7-TO for qemu-devel@nongnu.org; Mon, 24 Jan 2011 16:10:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhTfn-0007Ts-Ld for qemu-devel@nongnu.org; Mon, 24 Jan 2011 16:10:03 -0500 From: Kevin Wolf Date: Mon, 24 Jan 2011 22:10:43 +0100 Message-Id: <1295903452-18017-15-git-send-email-kwolf@redhat.com> In-Reply-To: <1295903452-18017-1-git-send-email-kwolf@redhat.com> References: <1295903452-18017-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 14/23] qed: Refuse to create images on block devices List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Hajnoczi QED relies on the underlying filesystem to extend the file and maintain its size. Check that images are not created on a block device. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qed.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/block/qed.c b/block/qed.c index 085c4f2..a46f9ef 100644 --- a/block/qed.c +++ b/block/qed.c @@ -469,6 +469,12 @@ static int qed_create(const char *filename, uint32_t cluster_size, return ret; } + /* File must start empty and grow, check truncate is supported */ + ret = bdrv_truncate(bs, 0); + if (ret < 0) { + goto out; + } + if (backing_file) { header.features |= QED_F_BACKING_FILE; header.backing_filename_offset = sizeof(le_header); -- 1.7.2.3