From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 07/23] ide: also reset io_buffer_index for writes
Date: Mon, 24 Jan 2011 22:10:36 +0100 [thread overview]
Message-ID: <1295903452-18017-8-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1295903452-18017-1-git-send-email-kwolf@redhat.com>
From: Christoph Hellwig <hch@lst.de>
Currenly the code only resets the io_buffer_index field for reads,
but the code seems to expect this for all types of I/O. I guess
we simply don't hit large enough transfers that would require this
often enough.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/ide/core.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index e93dd46..12b9c53 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -521,8 +521,7 @@ void ide_dma_cb(void *opaque, int ret)
/* launch next transfer */
n = s->nsector;
- if (s->is_read)
- s->io_buffer_index = 0;
+ s->io_buffer_index = 0;
s->io_buffer_size = n * 512;
if (s->bus->dma->ops->prepare_buf(s->bus->dma, s->is_read) == 0)
goto eot;
--
1.7.2.3
next prev parent reply other threads:[~2011-01-24 21:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 21:10 [Qemu-devel] [PULL 00/23] Block patches Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 01/23] qcow2: fix unaligned access Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 02/23] qemu-img snapshot: Use writeback caching Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 03/23] do_snapshot_blkdev() error on missing snapshot_file argument Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 04/23] Make strtosz() return int64_t instead of ssize_t Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 05/23] Avoid divide by zero when there is no block device to migrate Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 06/23] ide: factor dma handling helpers Kevin Wolf
2011-01-24 21:10 ` Kevin Wolf [this message]
2011-01-24 21:10 ` [Qemu-devel] [PATCH 08/23] ide: kill ide_dma_submit_check Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 09/23] qcow2: Add QcowCache Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 10/23] qcow2: Use QcowCache Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 11/23] qcow2: Batch flushes for COW Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 12/23] ide: Remove unneeded null pointer check Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 13/23] Documentation: Add qemu-img check/rebase Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 14/23] qed: Refuse to create images on block devices Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 15/23] Fix block migration when the device size is not a multiple of 1 MB Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 16/23] blockdev: Fix error message for invalid -drive CHS Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 17/23] blockdev: Make drive_init() use error_report() Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 18/23] blockdev: Fix drive_del not to crash when drive is not in use Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 19/23] block: Use backing format driver during image creation Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 20/23] scsi-disk: Allow overriding SCSI INQUIRY removable bit Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 21/23] scsi: Allow scsi_bus_legacy_add_drive() to set " Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 22/23] usb-msd: Propagate removable bit to SCSI device Kevin Wolf
2011-01-24 21:10 ` [Qemu-devel] [PATCH 23/23] docs: Document scsi-disk and usb-storage removable parameter Kevin Wolf
2011-01-24 21:54 ` [Qemu-devel] Re: [PULL 00/23] Block patches Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295903452-18017-8-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).