From: Pantelis Koukousoulas <pktoss@gmail.com>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] USB serial device support
Date: Mon, 18 May 2009 18:46:13 +0300 [thread overview]
Message-ID: <1295ed070905180846q188c5c01y1840cad58e45d24a@mail.gmail.com> (raw)
In-Reply-To: <1242658828-22556-4-git-send-email-jason.wessel@windriver.com>
On Mon, May 18, 2009 at 6:00 PM, Jason Wessel
<jason.wessel@windriver.com> wrote:
> Add in a workaround to allow the usb serial devices to work with the
> usb pass through mechanism. The ioctl() to request an alternate
> interface will always return < 0 for a usb-serial device based on the
> kernel driver. This means there is no alternate interface end point.
>
> This was fully tested with a pl2303 usb serial device.
>
> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
> ---
> usb-linux.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/usb-linux.c b/usb-linux.c
> index 70d7a1c..67e4acd 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -833,8 +833,7 @@ static int usb_linux_update_endp_table(USBHostDevice *s)
>
> ret = ioctl(s->fd, USBDEVFS_CONTROL, &ct);
> if (ret < 0) {
> - perror("usb_linux_update_endp_table");
> - return 1;
> + alt_interface = interface;
> }
>
> /* the current interface descriptor is the active interface
> --
> 1.6.3.1.9.g95405b
+1 for this patch.
I 've tested it with my UPS (usb-serial essentially), a usb-serial adaptor
but even my konig gamepad doesn't work without it.
tested-by: Pantelis Koukousoulas <pktoss@gmail.com>
prev parent reply other threads:[~2009-05-18 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 15:00 [Qemu-devel] [PATCH 0/3] usb and non usb serial improvements Jason Wessel
2009-05-18 15:00 ` [Qemu-devel] [PATCH 1/3] usb-serial: implement break event Jason Wessel
2009-05-18 15:00 ` [Qemu-devel] [PATCH 2/3] serial: fix lost character after sysrq Jason Wessel
2009-05-18 15:00 ` [Qemu-devel] [PATCH 3/3] USB serial device support Jason Wessel
2009-05-18 15:46 ` Pantelis Koukousoulas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295ed070905180846q188c5c01y1840cad58e45d24a@mail.gmail.com \
--to=pktoss@gmail.com \
--cc=jason.wessel@windriver.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).