* [Qemu-devel] [PATCH] target-arm: Fix Neon VQ(R)DMULH.S16 instructions
@ 2011-01-27 19:18 Peter Maydell
2011-01-29 14:18 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2011-01-27 19:18 UTC (permalink / raw)
To: qemu-devel; +Cc: patches
From: Juha Riihimäki <juha.riihimaki@nokia.com>
Correct an error in the implementation of the 16 bit
forms of VQ(R)DMULH, bringing them into line with the
32 bit implementation.
Signed-off-by: Juha Riihimäki <juha.riihimaki@nokia.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
target-arm/neon_helper.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
index 20f3c16..fead152 100644
--- a/target-arm/neon_helper.c
+++ b/target-arm/neon_helper.c
@@ -880,8 +880,9 @@ uint32_t HELPER(neon_cnt_u8)(uint32_t x)
if ((tmp ^ (tmp << 1)) & SIGNBIT) { \
SET_QC(); \
tmp = (tmp >> 31) ^ ~SIGNBIT; \
+ } else { \
+ tmp <<= 1; \
} \
- tmp <<= 1; \
if (round) { \
int32_t old = tmp; \
tmp += 1 << 15; \
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target-arm: Fix Neon VQ(R)DMULH.S16 instructions
2011-01-27 19:18 [Qemu-devel] [PATCH] target-arm: Fix Neon VQ(R)DMULH.S16 instructions Peter Maydell
@ 2011-01-29 14:18 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2011-01-29 14:18 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, patches
On Thu, Jan 27, 2011 at 07:18:35PM +0000, Peter Maydell wrote:
> From: Juha Riihimäki <juha.riihimaki@nokia.com>
>
> Correct an error in the implementation of the 16 bit
> forms of VQ(R)DMULH, bringing them into line with the
> 32 bit implementation.
>
> Signed-off-by: Juha Riihimäki <juha.riihimaki@nokia.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target-arm/neon_helper.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Thanks, applied.
> diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
> index 20f3c16..fead152 100644
> --- a/target-arm/neon_helper.c
> +++ b/target-arm/neon_helper.c
> @@ -880,8 +880,9 @@ uint32_t HELPER(neon_cnt_u8)(uint32_t x)
> if ((tmp ^ (tmp << 1)) & SIGNBIT) { \
> SET_QC(); \
> tmp = (tmp >> 31) ^ ~SIGNBIT; \
> + } else { \
> + tmp <<= 1; \
> } \
> - tmp <<= 1; \
> if (round) { \
> int32_t old = tmp; \
> tmp += 1 << 15; \
> --
> 1.7.1
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-29 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-27 19:18 [Qemu-devel] [PATCH] target-arm: Fix Neon VQ(R)DMULH.S16 instructions Peter Maydell
2011-01-29 14:18 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).