From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, geleman@gmail.com
Subject: [Qemu-devel] [PATCH] raw-win32: Fix bdrv_flush return value
Date: Fri, 28 Jan 2011 16:04:14 +0100 [thread overview]
Message-ID: <1296227054-13194-1-git-send-email-kwolf@redhat.com> (raw)
Reported-by: TeLeMan <geleman@gmail.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
Hi TeLeMan,
this seems to be the bug that was exposed by the recent qcow2 cache changes.
Can you give it a try on a real Windows setup? I have tested it only on Wine so
far.
Kevin
block/raw-win32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/raw-win32.c b/block/raw-win32.c
index 06c9710..c204a80 100644
--- a/block/raw-win32.c
+++ b/block/raw-win32.c
@@ -153,7 +153,7 @@ static int raw_flush(BlockDriverState *bs)
int ret;
ret = FlushFileBuffers(s->hfile);
- if (ret != 0) {
+ if (ret == 0) {
return -EIO;
}
--
1.7.2.3
next reply other threads:[~2011-01-28 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 15:04 Kevin Wolf [this message]
2011-01-29 1:06 ` [Qemu-devel] Re: [PATCH] raw-win32: Fix bdrv_flush return value TeLeMan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296227054-13194-1-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=geleman@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).