From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47693 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PipqY-0008Ed-Iy for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:02:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PipqT-0006bz-SF for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:02:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PipqT-0006bq-K1 for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:02:41 -0500 From: Kevin Wolf Date: Fri, 28 Jan 2011 16:04:14 +0100 Message-Id: <1296227054-13194-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] raw-win32: Fix bdrv_flush return value List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, geleman@gmail.com Reported-by: TeLeMan Signed-off-by: Kevin Wolf --- Hi TeLeMan, this seems to be the bug that was exposed by the recent qcow2 cache changes. Can you give it a try on a real Windows setup? I have tested it only on Wine so far. Kevin block/raw-win32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index 06c9710..c204a80 100644 --- a/block/raw-win32.c +++ b/block/raw-win32.c @@ -153,7 +153,7 @@ static int raw_flush(BlockDriverState *bs) int ret; ret = FlushFileBuffers(s->hfile); - if (ret != 0) { + if (ret == 0) { return -EIO; } -- 1.7.2.3