* [Qemu-devel] [PATCH] raw-win32: Fix bdrv_flush return value
@ 2011-01-28 15:04 Kevin Wolf
2011-01-29 1:06 ` [Qemu-devel] " TeLeMan
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2011-01-28 15:04 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, geleman
Reported-by: TeLeMan <geleman@gmail.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
Hi TeLeMan,
this seems to be the bug that was exposed by the recent qcow2 cache changes.
Can you give it a try on a real Windows setup? I have tested it only on Wine so
far.
Kevin
block/raw-win32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/raw-win32.c b/block/raw-win32.c
index 06c9710..c204a80 100644
--- a/block/raw-win32.c
+++ b/block/raw-win32.c
@@ -153,7 +153,7 @@ static int raw_flush(BlockDriverState *bs)
int ret;
ret = FlushFileBuffers(s->hfile);
- if (ret != 0) {
+ if (ret == 0) {
return -EIO;
}
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Qemu-devel] Re: [PATCH] raw-win32: Fix bdrv_flush return value
2011-01-28 15:04 [Qemu-devel] [PATCH] raw-win32: Fix bdrv_flush return value Kevin Wolf
@ 2011-01-29 1:06 ` TeLeMan
0 siblings, 0 replies; 2+ messages in thread
From: TeLeMan @ 2011-01-29 1:06 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
Thanks, It works very well on win7 and winxp.
--
SUN OF A BEACH
On Fri, Jan 28, 2011 at 23:04, Kevin Wolf <kwolf@redhat.com> wrote:
> Reported-by: TeLeMan <geleman@gmail.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>
> Hi TeLeMan,
>
> this seems to be the bug that was exposed by the recent qcow2 cache changes.
> Can you give it a try on a real Windows setup? I have tested it only on Wine so
> far.
>
> Kevin
>
>
> block/raw-win32.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/raw-win32.c b/block/raw-win32.c
> index 06c9710..c204a80 100644
> --- a/block/raw-win32.c
> +++ b/block/raw-win32.c
> @@ -153,7 +153,7 @@ static int raw_flush(BlockDriverState *bs)
> int ret;
>
> ret = FlushFileBuffers(s->hfile);
> - if (ret != 0) {
> + if (ret == 0) {
> return -EIO;
> }
>
> --
> 1.7.2.3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-29 1:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-28 15:04 [Qemu-devel] [PATCH] raw-win32: Fix bdrv_flush return value Kevin Wolf
2011-01-29 1:06 ` [Qemu-devel] " TeLeMan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).