qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Corentin Chary <corentincj@iksaif.net>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: Corentin Chary <corentincj@iksaif.net>,
	Andre Przywara <andre.przywara@amd.com>,
	Qemu-development List <qemu-devel@nongnu.org>,
	Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH v3 14/16] vnc: don't try to send bigger updates that client height
Date: Fri,  4 Feb 2011 09:06:06 +0100	[thread overview]
Message-ID: <1296806768-27787-15-git-send-email-corentincj@iksaif.net> (raw)
In-Reply-To: <1296806768-27787-1-git-send-email-corentincj@iksaif.net>

Respect client size if it doesn't not support desktop resizing.

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 ui/vnc.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/ui/vnc.c b/ui/vnc.c
index 6c57b0e..86c23207 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -795,12 +795,11 @@ static void vnc_dpy_cursor_define(QEMUCursor *c)
 }
 
 static int find_and_clear_dirty_height(struct VncState *vs,
-                                       int y, int last_x, int x)
+                                       int y, int last_x, int x, int height)
 {
     int h;
-    VncDisplay *vd = vs->vd;
 
-    for (h = 1; h < (vd->server->height - y); h++) {
+    for (h = 1; h < (height - y); h++) {
         int tmp_x;
         if (!test_bit(last_x, vs->dirty[y + h])) {
             break;
@@ -865,7 +864,8 @@ static int vnc_update_client(VncState *vs, int has_dirty)
                     }
                 } else {
                     if (last_x != -1) {
-                        int h = find_and_clear_dirty_height(vs, y, last_x, x);
+                        int h = find_and_clear_dirty_height(vs, y, last_x, x,
+                                                            height);
 
                         n += vnc_job_add_rect(job, last_x * 16, y,
                                               (x - last_x) * 16, h);
@@ -874,7 +874,7 @@ static int vnc_update_client(VncState *vs, int has_dirty)
                 }
             }
             if (last_x != -1) {
-                int h = find_and_clear_dirty_height(vs, y, last_x, x);
+                int h = find_and_clear_dirty_height(vs, y, last_x, x, height);
                 n += vnc_job_add_rect(job, last_x * 16, y,
                                       (x - last_x) * 16, h);
             }
-- 
1.7.3.4

  parent reply	other threads:[~2011-02-04  8:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-04  8:05 [Qemu-devel] [PATCH v3 00/16] vnc: adapative tight, zrle, zywrle, and bitmap module Corentin Chary
2011-02-04  8:05 ` [Qemu-devel] [PATCH v3 01/16] vnc: qemu can die if the client is disconnected while updating screen Corentin Chary
2011-02-04 12:51   ` Anthony Liguori
2011-02-07 16:38     ` Alexander Graf
2011-02-23 23:23   ` Anthony Liguori
2011-02-25 10:10     ` Corentin Chary
2011-02-04  8:05 ` [Qemu-devel] [PATCH v3 02/16] vnc: don't set the quality if lossy encoding are disabled Corentin Chary
2011-02-04  8:05 ` [Qemu-devel] [PATCH v3 03/16] vnc: add a way to get the update frequency for a given region Corentin Chary
2011-02-04  8:05 ` [Qemu-devel] [PATCH v3 04/16] vnc: refresh lossy rect after a given timeout Corentin Chary
2011-02-04  8:05 ` [Qemu-devel] [PATCH v3 05/16] vnc: tight: use the update frequency to choose between lossy and lossless Corentin Chary
2011-02-24 15:52   ` Peter Maydell
2011-02-04  8:05 ` [Qemu-devel] [PATCH v3 06/16] vnc: palette: use a pool to reduce memory allocations Corentin Chary
2011-02-04  8:05 ` [Qemu-devel] [PATCH v3 07/16] vnc: palette: add palette_init calls Corentin Chary
2011-02-04  8:06 ` [Qemu-devel] [PATCH v3 08/16] vnc: palette: and fill and color calls Corentin Chary
2011-02-04  8:06 ` [Qemu-devel] [PATCH v3 09/16] vnc: Add ZRLE and ZYWRLE encodings Corentin Chary
2011-02-04  8:06 ` [Qemu-devel] [PATCH v3 10/16] vnc: fix uint8_t comparisons with negative values Corentin Chary
2011-02-04  8:06 ` [Qemu-devel] [PATCH v3 11/16] vnc: fix lossy rect refreshing Corentin Chary
2011-02-04  8:06 ` [Qemu-devel] [PATCH v3 12/16] bitmap: add a generic bitmap and bitops library Corentin Chary
2011-02-04  8:06 ` [Qemu-devel] [PATCH v3 13/16] vnc: use the new generic bitmap functions Corentin Chary
2011-02-04  8:06 ` Corentin Chary [this message]
2011-02-04  8:06 ` [Qemu-devel] [PATCH v3 15/16] vnc: tight: tweak adaptive tight settings Corentin Chary
2011-02-04  8:06 ` [Qemu-devel] [PATCH v3 16/16] vnc: add a non-adaptive option Corentin Chary
2011-02-24 21:03 ` [Qemu-devel] [PATCH v3 00/16] vnc: adapative tight, zrle, zywrle, and bitmap module Stefan Weil
2011-02-24 21:42   ` Stefan Weil
2011-02-24 22:43   ` Corentin Chary
2011-02-25 17:57     ` Blue Swirl
2011-02-25 18:09     ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296806768-27787-15-git-send-email-corentincj@iksaif.net \
    --to=corentincj@iksaif.net \
    --cc=agraf@suse.de \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=andre.przywara@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).