From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58777 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PmQMk-0004t8-KZ for qemu-devel@nongnu.org; Mon, 07 Feb 2011 07:38:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PmQMj-000878-Bw for qemu-devel@nongnu.org; Mon, 07 Feb 2011 07:38:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PmQMj-000870-3i for qemu-devel@nongnu.org; Mon, 07 Feb 2011 07:38:49 -0500 From: Kevin Wolf Date: Mon, 7 Feb 2011 13:40:17 +0100 Message-Id: <1297082430-628-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1297082430-628-1-git-send-email-kwolf@redhat.com> References: <1297082430-628-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 01/14] qcow2: Really use cache=unsafe for image creation List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org For cache=unsafe we also need to set BDRV_O_CACHE_WB, otherwise we have some strange unsafe writethrough mode. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index dbe4fdd..a1773e4 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -975,7 +975,8 @@ static int qcow2_create2(const char *filename, int64_t total_size, */ BlockDriver* drv = bdrv_find_format("qcow2"); assert(drv != NULL); - ret = bdrv_open(bs, filename, BDRV_O_RDWR | BDRV_O_NO_FLUSH, drv); + ret = bdrv_open(bs, filename, + BDRV_O_RDWR | BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH, drv); if (ret < 0) { goto out; } -- 1.7.2.3