From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58830 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PmQMn-0004vX-HQ for qemu-devel@nongnu.org; Mon, 07 Feb 2011 07:38:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PmQMm-00088J-25 for qemu-devel@nongnu.org; Mon, 07 Feb 2011 07:38:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PmQMl-000881-Qt for qemu-devel@nongnu.org; Mon, 07 Feb 2011 07:38:52 -0500 From: Kevin Wolf Date: Mon, 7 Feb 2011 13:40:19 +0100 Message-Id: <1297082430-628-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1297082430-628-1-git-send-email-kwolf@redhat.com> References: <1297082430-628-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 03/14] block/vdi: Fix wrong size in conditionally used memset, memcmp List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Weil Error report from cppcheck: block/vdi.c:122: error: Using sizeof for array given as function argument returns the size of pointer. block/vdi.c:128: error: Using sizeof for array given as function argument returns the size of pointer. Fix both by setting the correct size. The buggy code is only used when QEMU is build without uuid support. The bug is not critical, so there is no urgent need to apply it to old versions of QEMU. Cc: Kevin Wolf Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf --- block/vdi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index ab8f70f..116b25b 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -119,13 +119,13 @@ void uuid_unparse(const uuid_t uu, char *out); #if !defined(CONFIG_UUID) void uuid_generate(uuid_t out) { - memset(out, 0, sizeof(out)); + memset(out, 0, sizeof(uuid_t)); } int uuid_is_null(const uuid_t uu) { uuid_t null_uuid = { 0 }; - return memcmp(uu, null_uuid, sizeof(uu)) == 0; + return memcmp(uu, null_uuid, sizeof(uuid_t)) == 0; } void uuid_unparse(const uuid_t uu, char *out) -- 1.7.2.3