qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [STABLE 0.14][PATCH 10/14] block-migration: actually disable dirty tracking on cleanup
Date: Mon,  7 Feb 2011 13:46:32 +0100	[thread overview]
Message-ID: <1297082796-1369-11-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1297082796-1369-1-git-send-email-kwolf@redhat.com>

From: Marcelo Tosatti <mtosatti@redhat.com>

Call to set_dirty_tracking() is misplaced.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 8f794c557c4b51c7a957d47ef6a2230114bb9e79)
---
 block-migration.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/block-migration.c b/block-migration.c
index c9d3e81..483ca7b 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -533,6 +533,8 @@ static void blk_mig_cleanup(Monitor *mon)
     BlkMigDevState *bmds;
     BlkMigBlock *blk;
 
+    set_dirty_tracking(0);
+
     while ((bmds = QSIMPLEQ_FIRST(&block_mig_state.bmds_list)) != NULL) {
         QSIMPLEQ_REMOVE_HEAD(&block_mig_state.bmds_list, entry);
         qemu_free(bmds->aio_bitmap);
@@ -545,8 +547,6 @@ static void blk_mig_cleanup(Monitor *mon)
         qemu_free(blk);
     }
 
-    set_dirty_tracking(0);
-
     monitor_printf(mon, "\n");
 }
 
-- 
1.7.2.3

  parent reply	other threads:[~2011-02-07 12:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 12:46 [Qemu-devel] [STABLE 0.14][PULL 00/14] Block patches for stable-0.14 Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 01/14] qcow2: Really use cache=unsafe for image creation Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 02/14] Documentation: add Sheepdog disk images Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 03/14] block/vdi: Fix wrong size in conditionally used memset, memcmp Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 04/14] ahci: split ICH9 from core Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 05/14] ahci: add license header in ahci.h Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 06/14] ahci: split ICH and AHCI even more Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 07/14] ahci: send init d2h fis on fis enable Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 08/14] ahci: Implement HBA reset Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 09/14] ahci: make number of ports runtime determined Kevin Wolf
2011-02-07 12:46 ` Kevin Wolf [this message]
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 11/14] blockdev: add refcount to DriveInfo Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 12/14] block-migration: add reference to target DriveInfo Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 13/14] Add flag to indicate external users to block device Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 14/14] block: enable in_use flag Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297082796-1369-11-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).