From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [STABLE 0.14][PATCH 12/14] block-migration: add reference to target DriveInfo
Date: Mon, 7 Feb 2011 13:46:34 +0100 [thread overview]
Message-ID: <1297082796-1369-13-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1297082796-1369-1-git-send-email-kwolf@redhat.com>
From: Marcelo Tosatti <mtosatti@redhat.com>
So that ejection of attached device by guest does not free data
in use by block migration instance.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
CC: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit f48905d44f670cd83227b3a8d06ae1406f0c771c)
---
block-migration.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/block-migration.c b/block-migration.c
index 483ca7b..323e1e2 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -19,6 +19,7 @@
#include "monitor.h"
#include "block-migration.h"
#include "migration.h"
+#include "blockdev.h"
#include <assert.h>
#define BLOCK_SIZE (BDRV_SECTORS_PER_DIRTY_CHUNK << BDRV_SECTOR_BITS)
@@ -299,6 +300,7 @@ static void init_blk_migration_it(void *opaque, BlockDriverState *bs)
bmds->completed_sectors = 0;
bmds->shared_base = block_mig_state.shared_base;
alloc_aio_bitmap(bmds);
+ drive_get_ref(drive_get_by_blockdev(bs));
block_mig_state.total_sector_sum += sectors;
@@ -537,6 +539,7 @@ static void blk_mig_cleanup(Monitor *mon)
while ((bmds = QSIMPLEQ_FIRST(&block_mig_state.bmds_list)) != NULL) {
QSIMPLEQ_REMOVE_HEAD(&block_mig_state.bmds_list, entry);
+ drive_put_ref(drive_get_by_blockdev(bmds->bs));
qemu_free(bmds->aio_bitmap);
qemu_free(bmds);
}
--
1.7.2.3
next prev parent reply other threads:[~2011-02-07 12:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 12:46 [Qemu-devel] [STABLE 0.14][PULL 00/14] Block patches for stable-0.14 Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 01/14] qcow2: Really use cache=unsafe for image creation Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 02/14] Documentation: add Sheepdog disk images Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 03/14] block/vdi: Fix wrong size in conditionally used memset, memcmp Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 04/14] ahci: split ICH9 from core Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 05/14] ahci: add license header in ahci.h Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 06/14] ahci: split ICH and AHCI even more Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 07/14] ahci: send init d2h fis on fis enable Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 08/14] ahci: Implement HBA reset Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 09/14] ahci: make number of ports runtime determined Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 10/14] block-migration: actually disable dirty tracking on cleanup Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 11/14] blockdev: add refcount to DriveInfo Kevin Wolf
2011-02-07 12:46 ` Kevin Wolf [this message]
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 13/14] Add flag to indicate external users to block device Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 14/14] block: enable in_use flag Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297082796-1369-13-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).