qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [STABLE 0.14][PATCH 13/14] Add flag to indicate external users to block device
Date: Mon,  7 Feb 2011 13:46:35 +0100	[thread overview]
Message-ID: <1297082796-1369-14-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1297082796-1369-1-git-send-email-kwolf@redhat.com>

From: Marcelo Tosatti <mtosatti@redhat.com>

Certain operations such as drive_del or resize cannot be performed
while external users (eg. block migration) reference the block device.

Add a flag to indicate that.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit db593f2565dc12442d6bac9e8eaefa027dfcada9)
---
 block.c     |   11 +++++++++++
 block.h     |    2 ++
 block_int.h |    1 +
 3 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/block.c b/block.c
index 998df1b..ee9edfc 100644
--- a/block.c
+++ b/block.c
@@ -2774,6 +2774,17 @@ int64_t bdrv_get_dirty_count(BlockDriverState *bs)
     return bs->dirty_count;
 }
 
+void bdrv_set_in_use(BlockDriverState *bs, int in_use)
+{
+    assert(bs->in_use != in_use);
+    bs->in_use = in_use;
+}
+
+int bdrv_in_use(BlockDriverState *bs)
+{
+    return bs->in_use;
+}
+
 int bdrv_img_create(const char *filename, const char *fmt,
                     const char *base_filename, const char *base_fmt,
                     char *options, uint64_t img_size, int flags)
diff --git a/block.h b/block.h
index 239f729..19f4768 100644
--- a/block.h
+++ b/block.h
@@ -241,6 +241,8 @@ void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector,
                       int nr_sectors);
 int64_t bdrv_get_dirty_count(BlockDriverState *bs);
 
+void bdrv_set_in_use(BlockDriverState *bs, int in_use);
+int bdrv_in_use(BlockDriverState *bs);
 
 typedef enum {
     BLKDBG_L1_UPDATE,
diff --git a/block_int.h b/block_int.h
index 6ebdc3e..545ad11 100644
--- a/block_int.h
+++ b/block_int.h
@@ -199,6 +199,7 @@ struct BlockDriverState {
     char device_name[32];
     unsigned long *dirty_bitmap;
     int64_t dirty_count;
+    int in_use; /* users other than guest access, eg. block migration */
     QTAILQ_ENTRY(BlockDriverState) list;
     void *private;
 };
-- 
1.7.2.3

  parent reply	other threads:[~2011-02-07 12:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 12:46 [Qemu-devel] [STABLE 0.14][PULL 00/14] Block patches for stable-0.14 Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 01/14] qcow2: Really use cache=unsafe for image creation Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 02/14] Documentation: add Sheepdog disk images Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 03/14] block/vdi: Fix wrong size in conditionally used memset, memcmp Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 04/14] ahci: split ICH9 from core Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 05/14] ahci: add license header in ahci.h Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 06/14] ahci: split ICH and AHCI even more Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 07/14] ahci: send init d2h fis on fis enable Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 08/14] ahci: Implement HBA reset Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 09/14] ahci: make number of ports runtime determined Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 10/14] block-migration: actually disable dirty tracking on cleanup Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 11/14] blockdev: add refcount to DriveInfo Kevin Wolf
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 12/14] block-migration: add reference to target DriveInfo Kevin Wolf
2011-02-07 12:46 ` Kevin Wolf [this message]
2011-02-07 12:46 ` [Qemu-devel] [STABLE 0.14][PATCH 14/14] block: enable in_use flag Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297082796-1369-14-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).