From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58281 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PmSyd-0001rZ-46
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:26:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PmSyb-00052o-Jh
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:26:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50840)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PmSyb-00052S-Cd
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:26:05 -0500
From: Alex Williamson <alex.williamson@redhat.com>
In-Reply-To: <70184bc75b64011db4a0610d60aad47dbf647cde.1297077507.git.jan.kiszka@siemens.com>
References: <cover.1297077506.git.jan.kiszka@siemens.com>
	<70184bc75b64011db4a0610d60aad47dbf647cde.1297077507.git.jan.kiszka@siemens.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 07 Feb 2011 08:26:02 -0700
Message-ID: <1297092362.3518.3.camel@x201>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 11/15] kvm: Remove unneeded memory slot
	reservation
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On Mon, 2011-02-07 at 12:19 +0100, Jan Kiszka wrote:
> The number of slots and the location of private ones changed several
> times in KVM's early days. However, it's stable since 2.6.29 (our
> required baseline), and slots 8..11 are no longer reserved since then.
> So remove this unneeded restriction.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> CC: Alex Williamson <alex.williamson@redhat.com>
> ---
>  kvm-all.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)

Acked-by: Alex Williamson <alex.williamson@redhat.com>

> diff --git a/kvm-all.c b/kvm-all.c
> index 802c6b8..14b6c1e 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -91,10 +91,6 @@ static KVMSlot *kvm_alloc_slot(KVMState *s)
>      int i;
>  
>      for (i = 0; i < ARRAY_SIZE(s->slots); i++) {
> -        /* KVM private memory slots */
> -        if (i >= 8 && i < 12) {
> -            continue;
> -        }
>          if (s->slots[i].memory_size == 0) {
>              return &s->slots[i];
>          }