qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 09/11] blockdev: Plug memory leak in drive_uninit()
Date: Thu, 10 Feb 2011 16:51:24 +0100	[thread overview]
Message-ID: <1297353086-4844-10-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1297353086-4844-1-git-send-email-kwolf@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

Started leaking in commit 1dae12e6.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 blockdev.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index ecfadc1..24d7658 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -182,6 +182,7 @@ static void drive_uninit(DriveInfo *dinfo)
 {
     qemu_opts_del(dinfo->opts);
     bdrv_delete(dinfo->bdrv);
+    qemu_free(dinfo->id);
     QTAILQ_REMOVE(&drives, dinfo, next);
     qemu_free(dinfo);
 }
-- 
1.7.2.3

  parent reply	other threads:[~2011-02-10 15:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10 15:51 [Qemu-devel] [PULL 00/11] Block patches for master Kevin Wolf
2011-02-10 15:51 ` [Qemu-devel] [PATCH 01/11] Change snapshot_blkdev hmp to use correct argument type for device Kevin Wolf
2011-02-10 15:51 ` [Qemu-devel] [PATCH 02/11] QCOW2: bug fix - read base image beyond its size Kevin Wolf
2011-02-10 15:51 ` [Qemu-devel] [PATCH 03/11] qcow2: Fix error handling for immediate backing file read failure Kevin Wolf
2011-02-10 15:51 ` [Qemu-devel] [PATCH 04/11] qcow2: Fix error handling for reading compressed clusters Kevin Wolf
2011-02-10 15:51 ` [Qemu-devel] [PATCH 05/11] qerror: Add QERR_UNKNOWN_BLOCK_FORMAT_FEATURE Kevin Wolf
2011-02-10 15:51 ` [Qemu-devel] [PATCH 06/11] qcow2: Report error for version > 2 Kevin Wolf
2011-02-10 15:51 ` [Qemu-devel] [PATCH 07/11] qed: Report error for unsupported features Kevin Wolf
2011-02-10 15:51 ` [Qemu-devel] [PATCH 08/11] qemu-img: Improve error messages for failed bdrv_open Kevin Wolf
2011-02-10 15:51 ` Kevin Wolf [this message]
2011-02-10 15:51 ` [Qemu-devel] [PATCH 10/11] blockdev: Plug memory leak in drive_init() error paths Kevin Wolf
2011-02-10 15:51 ` [Qemu-devel] [PATCH 11/11] qcow2: Fix order in L2 table COW Kevin Wolf
2011-02-14 20:17 ` [Qemu-devel] [PULL 00/11] Block patches for master Anthony Liguori
2011-02-16 11:30   ` Kevin Wolf
2011-02-16 12:00     ` [Qemu-devel] " Paolo Bonzini
2011-02-16 14:47       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297353086-4844-10-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).