From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36801 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnaSx-0006en-5p for qemu-devel@nongnu.org; Thu, 10 Feb 2011 12:38:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PnaSv-0004TQ-Gf for qemu-devel@nongnu.org; Thu, 10 Feb 2011 12:38:03 -0500 Received: from mail-gx0-f173.google.com ([209.85.161.173]:54192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PnaSv-0004TG-BQ for qemu-devel@nongnu.org; Thu, 10 Feb 2011 12:38:01 -0500 Received: by gxk28 with SMTP id 28so757194gxk.4 for ; Thu, 10 Feb 2011 09:38:00 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 10 Feb 2011 18:37:40 +0100 Message-Id: <1297359464-9789-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1297359464-9789-1-git-send-email-pbonzini@redhat.com> References: <1297359464-9789-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 3/7] use win32 timer queues List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl Multimedia timers are only useful for compatibility with Windows NT 4.0 and earlier. Plus, the implementation in Wine is extremely heavyweight. Signed-off-by: Paolo Bonzini Cc: Stefan Weil Cc: Blue Swirl --- qemu-timer.c | 86 +++++++++++++++++++++++---------------------------------- 1 files changed, 35 insertions(+), 51 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 42960de..a2bac99 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -202,11 +202,6 @@ static void qemu_rearm_alarm_timer(struct qemu_alarm_timer *t) #ifdef _WIN32 -struct qemu_alarm_win32 { - MMRESULT timerId; - unsigned int period; -} alarm_win32_data = {0, 0}; - static int win32_start_timer(struct qemu_alarm_timer *t); static void win32_stop_timer(struct qemu_alarm_timer *t); static void win32_rearm_timer(struct qemu_alarm_timer *t); @@ -300,9 +295,9 @@ static struct qemu_alarm_timer alarm_timers[] = { {"unix", unix_start_timer, unix_stop_timer, NULL, NULL}, #else {"dynticks", win32_start_timer, - win32_stop_timer, win32_rearm_timer, &alarm_win32_data}, + win32_stop_timer, win32_rearm_timer, NULL}, {"win32", win32_start_timer, - win32_stop_timer, NULL, &alarm_win32_data}, + win32_stop_timer, NULL, NULL}, #endif {NULL, } }; @@ -638,9 +633,7 @@ void qemu_run_all_timers(void) static int64_t qemu_next_alarm_deadline(void); #ifdef _WIN32 -static void CALLBACK host_alarm_handler(UINT uTimerID, UINT uMsg, - DWORD_PTR dwUser, DWORD_PTR dw1, - DWORD_PTR dw2) +static void CALLBACK host_alarm_handler(PVOID lpParam, BOOLEAN unused) #else static void host_alarm_handler(int host_signum) #endif @@ -963,50 +956,45 @@ static void unix_stop_timer(struct qemu_alarm_timer *t) static int win32_start_timer(struct qemu_alarm_timer *t) { - TIMECAPS tc; - struct qemu_alarm_win32 *data = t->priv; - UINT flags; - - memset(&tc, 0, sizeof(tc)); - timeGetDevCaps(&tc, sizeof(tc)); - - data->period = tc.wPeriodMin; - timeBeginPeriod(data->period); - - flags = TIME_CALLBACK_FUNCTION; - if (alarm_has_dynticks(t)) - flags |= TIME_ONESHOT; - else - flags |= TIME_PERIODIC; - - data->timerId = timeSetEvent(1, // interval (ms) - data->period, // resolution - host_alarm_handler, // function - (DWORD)t, // parameter - flags); - - if (!data->timerId) { + HANDLE hTimer; + BOOLEAN success; + + /* If you call ChangeTimerQueueTimer on a one-shot timer (its period + is zero) that has already expired, the timer is not updated. Since + creating a new timer is relatively expensive, set a bogus one-hour + interval in the dynticks case. */ + success = CreateTimerQueueTimer(&hTimer, + NULL, + host_alarm_handler, + t, + 1, + alarm_has_dynticks(t) ? 3600000 : 1, + WT_EXECUTEINTIMERTHREAD); + + if (!success) { fprintf(stderr, "Failed to initialize win32 alarm timer: %ld\n", GetLastError()); - timeEndPeriod(data->period); return -1; } + t->priv = (PVOID) hTimer; return 0; } static void win32_stop_timer(struct qemu_alarm_timer *t) { - struct qemu_alarm_win32 *data = t->priv; + HANDLE hTimer = t->priv; - timeKillEvent(data->timerId); - timeEndPeriod(data->period); + if (hTimer) { + DeleteTimerQueueTimer(NULL, hTimer, NULL); + } } static void win32_rearm_timer(struct qemu_alarm_timer *t) { - struct qemu_alarm_win32 *data = t->priv; + HANDLE hTimer = t->priv; int nearest_delta_ms; + BOOLEAN success; assert(alarm_has_dynticks(t)); if (!active_timers[QEMU_CLOCK_REALTIME] && @@ -1014,24 +1002,20 @@ static void win32_rearm_timer(struct qemu_alarm_timer *t) !active_timers[QEMU_CLOCK_HOST]) return; - timeKillEvent(data->timerId); - nearest_delta_ms = (qemu_next_alarm_deadline() + 999999) / 1000000; if (nearest_delta_ms < 1) nearest_delta_ms = 1; - data->timerId = timeSetEvent(nearest_delta_ms, - data->period, - host_alarm_handler, - (DWORD)t, - TIME_ONESHOT | TIME_CALLBACK_FUNCTION); - - if (!data->timerId) { - fprintf(stderr, "Failed to re-arm win32 alarm timer %ld\n", - GetLastError()); + success = ChangeTimerQueueTimer(NULL, + hTimer, + nearest_delta_ms, + 3600000); - timeEndPeriod(data->period); - exit(1); + if (!success) { + fprintf(stderr, "Failed to rearm win32 alarm timer: %ld\n", + GetLastError()); + exit(-1); } + } #endif /* _WIN32 */ -- 1.7.3.5